GithubHelp home page GithubHelp logo

Comments (14)

strk avatar strk commented on May 1, 2024

I generally agree on never keeping anything that's not source code into the repository.
What I've understood is that bindata.go is there to allow for "go get" to get you a compiled binary, so basically a workaround to a "go get" limitation. But I don't have further references about this limitation and other possible workarounds.

In all cases, I think it is acceptable to go get ...; less README.md; make;

from gitea.

tboerger avatar tboerger commented on May 1, 2024

I don't agree on that. There are no other ways to stay go gettable than adding bindata to the repo.

If there are other ways around we can talk about that.

from gitea.

tboerger avatar tboerger commented on May 1, 2024

BTW, go get will fail without the bindata because the imports can't be accomplished

from gitea.

strk avatar strk commented on May 1, 2024

@tboerger it will fail but will have downloaded all the sources, right ?

from gitea.

tboerger avatar tboerger commented on May 1, 2024

But if I go get something I expect to have it working without reading the readme to find out what else needs to be done

from gitea.

strk avatar strk commented on May 1, 2024

I'm not a long Go user enough to know what one would have to expect by "go get". I've read it's not a package manager, but I do see it being used as such

from gitea.

strk avatar strk commented on May 1, 2024

For the PR mess (conflicts and changelogs size), I shall note that @unkwon used to only update bindata.go before releases, and not accepting those updates in the PRs themselves.

from gitea.

tboerger avatar tboerger commented on May 1, 2024

I would suggest an additional commit made by the CI system that updates the bindata.

from gitea.

strk avatar strk commented on May 1, 2024

If bindata.go has to stay, +1 for the CI system automation (only if it would change).
But I'd really prefer to give-up go-get'ability than keeping generated files in the repo.
How about making bindata.go usage optional, so to retain go-getability while still allowing bindata.go usage upon request ?

from gitea.

strk avatar strk commented on May 1, 2024

@tboerger is the optional bindata.go what you'd get with build tags ? (#74 (comment))

from gitea.

strk avatar strk commented on May 1, 2024

My take on the optional embedding of files is in this PR: #78
I've understood @tboerger is also working on making embedding optional in his #74, but I think that PR also adds public and templates into the bindata, so maybe it make sense to divide the work in two steps, for easier reviews ?

from gitea.

strk avatar strk commented on May 1, 2024

For reference, @tboerger PR about conditional bindata embedding is #30 (came out in gitter chat)

from gitea.

strk avatar strk commented on May 1, 2024

So, should this be closed as a duplicate of #30 ?

from gitea.

tboerger avatar tboerger commented on May 1, 2024

Duplicate of #30

from gitea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.