GithubHelp home page GithubHelp logo

Comments (2)

System-Glitch avatar System-Glitch commented on July 23, 2024

I like the idea but this is a breaking change. The function signature is also already pretty heavy with lots of parameters. If I were to change it, I would probably create a validation.Context struct containing everything the validators could need.

About your example, this is a wrong usage of validator. You are checking for permissions, and that should take place in middleware. That is because a validator returning false will result in a http.StatusUnprocessableEntity, while you should use http.StatusUnauthorized instead.

I don't think that change would require a reorganization of the structure because we could just pass the request.Extra map to the validator, without the need for an import of the main package. I don't think validators need (nor should) get any other information from the request to avoid them going beyond their primary goal.

from goyave.

Clement3 avatar Clement3 commented on July 23, 2024

Sorry for the late response.
Indeed, maybe it wasn’t the best example to give, but you understood what I needed.
Your solution allows to have custom fields without having to pass the Request entirely which solve the problem.

from goyave.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.