Comments (4)
@vmihailenco in the analogy, wouldn't requests fail when the bucket is full? New requests raise the water level and leak out when complete? In that interpretation I think everything works.
Either way the result is that the rate limiter doesn't rate limit so shouldn't this be patched?
from redis_rate.
In the leaking bucket analogy the burst is the initial water level in the bucket. Without it the first call to the rate limiter will fail (bucket will be empty).
from redis_rate.
@jose-zenledger your analogy makes sense with how leaky bucket works, not sure what @vmihailenco is saying here
from redis_rate.
@vmihailenco in the analogy, wouldn't requests fail when the bucket is full? New requests raise the water level and leak out when complete? In that interpretation I think everything works.
Either way the result is that the rate limiter doesn't rate limit so shouldn't this be patched?
I feel like it's more a token bucket than a leaky bucket. That's why the water level is zero, you can not have request. the water level here works like a token.
from redis_rate.
Related Issues (20)
- Tests are failing when actual redis server is used
- Update godoc version in repo about
- Redis Pool Timeout over 1500 rps
- How to deal with this speed limit scheme?
- how to clear old keys?
- Dependency Dashboard
- questions about allown and allownMost
- Latency benchmarks
- Rate limiter not working as expected HOT 4
- Support go-redis v9? HOT 4
- Export rediser interface
- Problem with package "go-redis/redis/v10" vs "redis/go-redis/v10" HOT 1
- redis_rate.PerDay() ?? HOT 2
- dose lua script length limit?
- v is nil,occured pannic error HOT 1
- Delay returned by Allow* methods not explained
- why burst_offset is neccessary HOT 1
- Rate and Burst configurations are not clear
- ERR bad lua script for redis cluster, all the keys that the script uses should be passed using the KEYS array, and KEYS should not be in expression
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redis_rate.