GithubHelp home page GithubHelp logo

Comments (4)

jose-zenledger avatar jose-zenledger commented on June 10, 2024 1

@vmihailenco in the analogy, wouldn't requests fail when the bucket is full? New requests raise the water level and leak out when complete? In that interpretation I think everything works.

Either way the result is that the rate limiter doesn't rate limit so shouldn't this be patched?

from redis_rate.

vmihailenco avatar vmihailenco commented on June 10, 2024

In the leaking bucket analogy the burst is the initial water level in the bucket. Without it the first call to the rate limiter will fail (bucket will be empty).

from redis_rate.

aleksficek avatar aleksficek commented on June 10, 2024

@jose-zenledger your analogy makes sense with how leaky bucket works, not sure what @vmihailenco is saying here

from redis_rate.

whongki avatar whongki commented on June 10, 2024

@vmihailenco in the analogy, wouldn't requests fail when the bucket is full? New requests raise the water level and leak out when complete? In that interpretation I think everything works.

Either way the result is that the rate limiter doesn't rate limit so shouldn't this be patched?

I feel like it's more a token bucket than a leaky bucket. That's why the water level is zero, you can not have request. the water level here works like a token.

from redis_rate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.