Clarify how WaitRequestIdle() should be used. about rod

[alufrew]

Ok. I will do it slightly later. Leaving issue opened till then.

…

On May 4, 2020, at 3:25 PM, Yad Smood ***@***.***> wrote: Agree, if you can make a PR to fix the doc, I'll be more than happy to merge! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO4BNGYVHKUMLXVS5EMEV7LRP2X4JANCNFSM4MYV7OZQ>.

[alufrew]

I see you already closed issue. Sorry that you had to do it yourself. Was away for a while. Won't happen next time.

[ysmood]

The wait is only for the next request. If you have another request you have to create another wait:

package main

import (
	"fmt"
	"time"

	"github.com/ysmood/rod"
	"github.com/ysmood/rod/lib/launcher"
)

func main() {
	url := launcher.New().
		Headless(false).
		Launch()

	b := rod.New().ControlURL(url).Connect().Timeout(30 * time.Second)
	defer b.Close()

	page := b.Page("https://google.com")
	w := page.WaitRequestIdle()

	page.Navigate("https://wikipedia.org")
	fmt.Println(time.Now())
	w()
	fmt.Println(time.Now())

	w := page.WaitRequestIdle()  // look at this line!

	page.Navigate("https://gmail.com")
	fmt.Println(time.Now())
	w()
	fmt.Println(time.Now())
}

[ysmood]

If you want more options, you can use WaitRequestIdleE other than the high-level version WaitRequestIdle

[ysmood]

BTW, for page load events it's better to use page.WaitLoad(), WaitRequestIdle is designed for ajax requests when you click some button on the page.

[ysmood]

Usually, you don't need to use WaitRequestIdle or WaitLoad at all, you can directly use the selector page.Element, it will automatically retry until it finds the element.

[alufrew]

Oh. Thanks. I misunderstood how it should work.

I really need WaitRequestIdle. In my case all elements can be already on page but background requests are still running. If I f.e. click on element before requests stop sometimes I receive unexpected behaviour. So after clicking on some element I want to wait while requests are finished before clicking next.

May I propose to slightly change doc string for WaitRequestIdle to empathize that function returned will only be used for one next request?

[ysmood]

Agree, if you can make a PR to fix the doc, I'll be more than happy to merge!

[ysmood]

Never mind. Looking forward to your idea and contribution 😃