How should I use proxy with username and password about rod

[ysmood]

You can set the request auth header by this API: https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setExtraHTTPHeaders

The header looks like this Proxy-Authorization: Basic dXNlcjpwYXNzd29yZA==.

dXNlcjpwYXNzd29yZA== is base64 of user:password

[zjlx]

I try it :
page.Call("Network.setExtraHTTPHeaders", cdp.Object{ "Proxy-Authorization": "Basic dXNlcjpwYXNzd29yZA==", })
the error is panic: {"code":-32602,"message":"Invalid parameters","data":"headers: object expected"}
Is the parameter format incorrect?

[ysmood]

The error message is already telling you you missed the headers 😂

It's like Call({ headers: { a: b } }), not Call({ a: b })

[ysmood]

BTW, I added page.SetExtraHeaders in version v0.29.1, you can use that directly:

This is the example code:

https://github.com/ysmood/rod/blob/f397ccbb88efc50352fc97574d71b0d3655a8755/page_test.go#L57

[ysmood]

The new version of Rod is type-safe when you send low-level requests to chrome. This kind of issue won't happen again, check the example:

https://github.com/ysmood/rod/blob/3ff68f7d645f24c0978878939164f01bd39d88a2/examples_test.go#L175

[zjlx]

I use page.SetExtraHeaders("Proxy-Authorization", "Basic "+temp) but it not work , is it rigth?
key/value use comma separated?
Can you change it to
var dict map[string]string = map[string]string{"Proxy-Authorization":"Basic "+temp} page.SetExtraHeaders(dict)
And v0.29.1 can't use Call and Cdp.Object anymore?

[ysmood]

Check my previous comment, it's type-safe now, that's the new way to use the low-level API, cdp.Object is not type-safe.

If you really want to use raw json, you can do something like:

	// Or even more lower way to use raw json to send request to chrome.
	ctx, client, sessionID := page.CallContext()
	client.Call(ctx, sessionID, "Network.SetCookie", map[string]string{
		"name":  "rod",
		"value": "test",
		"url":   "https://github.com",
	})

vs

	proto.NetworkSetCookie{
		Name:  "rod",
		Value: "test",
		URL:   "https://github.com",
	}.Call(page)

These two ways are the same.

[ysmood]

with map[string]string you have to write more code.

SetHeaders(map[string]string{"a": "b"})

vs

SetHeaders("a", "b")

The later is obviously shorter. When you have multiple pairs, you can do:

SetHeaders(
  "key1", "value1",
  "key2", "value2",
)

[ysmood]

Thanks for your report. The v0.30.1 added the HandleAuth helper to deal with your problem.

I tested with mitmproxy --showhost --proxyauth a:b, it works well.

Here's the example to use it:

https://github.com/ysmood/rod/blob/3ae35ce463f28e3ce8055e6dafda5eb33f39fc53/browser_test.go#L70

[ysmood]

@zjlx about the breaking change issue, check this answer: How versioning is handled

[zjlx]

Thanks for your report. The v0.30.1 added the HandleAuth helper to deal with your problem.

I tested with mitmproxy --showhost --proxyauth a:b, it works well.

Here's the example to use it:

https://github.com/ysmood/rod/blob/3ae35ce463f28e3ce8055e6dafda5eb33f39fc53/browser_test.go#L70

Thank you so much for the changes. It is working well.