Full page screenshot? about rod

[ysmood]

Let's keep this ticket open since the full-page screenshot is actually useful. I just don't have enough time to implement it. The common solution is to take multiple shots while scrolling down the page until it hits the bottom, then merge all those shots into one.

If you are interested in it, it'll be great if you can help to implement it.

[ysmood]

If your chrome version is too old, it doesn't support the PDF API.

The way you code it is similar to puppeteer, which changes the size of the frame. But puppeteer uses Emulation.setDeviceMetricsOverride to do it:

https://github.com/puppeteer/puppeteer/blob/caaf4d2086036d4bf201587529dd3e3b38b6f9c6/src/Page.ts#L1058-L1064

I think this kind of solution is good to have.

[ysmood]

To make the chrome version consistent, you can download a specific version of chrome and specified the bin location:

launcher.New().Bin("the_path_of_chrome")

Or you can check this FAQ to use docker: https://github.com/ysmood/rod#q-how-to-use-rod-with-docker

[ysmood]

Published v0.34.2 with the full page screenshot feature.

I changed the name to SceenshotFullPage, so that when user types Screenshot the IDE will give the user a list to choose which one to use.

Because of the retina scale bug, I have to revert the GetViewport, the safest way to do it is to store a private viewport whenever we set it, once chrome adds the API to retrieve the metrics we can optimize it.

[youshy]

Good call!

I'll close this one for now then. If you have any more tasks or functionalities you want to implement - hit me up, happy to help :) (I'll probably learn some stuff while using the lib tho, will try to add them here as I go)

[ysmood]

How about to use page.PDF()?

[youshy]

I've ended up writing this:

func UseRod(link string) {
	url := launcher.New().
		Headless(false).
		Devtools(false).
		Launch()

	browser := rod.New().
		ControlURL(url).
		Trace(false).
		Connect().
		Timeout(time.Minute)

	defer browser.Close()
	page := browser.Timeout(time.Minute).Page(link)
	wait := page.WaitRequestIdle()
	wait()
	height := page.Eval(`() => document.body.clientHeight`).String()
	heightToInt, err := strconv.ParseInt(height, 10, 64)
	if err != nil {
		log.Fatalln(err)
	}
	page.Viewport(1920, heightToInt, 1, false)
	toByte, err := page.ScreenshotE(&proto.PageCaptureScreenshot{})

	f, err := os.Create("img_2.png")
	if err != nil {
		log.Fatal(err)
	}
	defer f.Close()
	img, _, _ := image.Decode(bytes.NewReader(toByte))
	err = png.Encode(f, img)
	if err != nil {
		log.Fatal(err)
	}
}

but will try the page.PDF() as well! My solution is a tad verbose... 😆

[youshy]

Both page.PDF() and page.PDFE() returns

2020/05/19 15:37:54 {"code":-32000,"message":"PrintToPDF is not implemented","data":""}

@ysmood I'm more than happy with helping!