bug (vela-github-release): files parameter doesn't seem to accept a glob about community

[colindean]

Interestingly, enough, the file thing isn't working, either. The file contains literally

ai_engineer_capabilities_etc.pdf ai_engineer_training_program.pdf

no whitespace, either:

00000000  61 69 5f 65 6e 67 69 6e  65 65 72 5f 63 61 70 61  |ai_engineer_capa|
00000010  62 69 6c 69 74 69 65 73  5f 65 74 63 2e 70 64 66  |bilities_etc.pdf|
00000020  20 61 69 5f 65 6e 67 69  6e 65 65 72 5f 74 72 61  | ai_engineer_tra|
00000030  69 6e 69 6e 67 5f 70 72  6f 67 72 61 6d 2e 70 64  |ining_program.pd|
00000040  66 0a                                             |f.|
00000042

and the build outputs:

$ /bin/gh release create 2022.11.17.24
 ai_engineer_capabilities_etc.pdf ai_engineer_training_program.pdf --draft=false --prerelease=false --target=main --title=v2022.11.17.24

stat ai_engineer_capabilities_etc.pdf ai_engineer_training_program.pdf: no such file or directory
exit status 1

I speculate that the way that the files option is getting appended to the command line is treating it as one string instead of an array of strings.

https://github.com/go-vela/vela-github-release/blob/59655a5c4e2c3a8e21112b641ebc331dacab6e7b/cmd/vela-github-release/create.go#L65-L66

The tests appear to be only ever testing with single-element arrays.

[colindean]

Poking around the source, I found that options that allow arrays must have those options separated by a comma when reading from a /vela/parameters file. Adding the , results in the command ~working (a different error in my case: bad tag 🙃 ).

[colindean]

I got bit by this again on another repo today. I found this issue faster this time, though ;-)

[wass3rw3rk]

i think you're correct, we'd have to either pass the command through sh -c or have Go expand the glob (which Go has it's own interpretation of, so it might not be what you'd expect depending on what you pass).