Seemingly impossible divide by zero exception thrown about konsole

[goblinfactory]

Hi @PromoFaux

You have unfortunately caught me in middle of migrating my development machine and I wont be able to investigate this for a bit. I spent some time looking at the code and at first I thought it had something to do with a float never equalling zero, where I might need to change some code to write an extension method along the lines of .IsCloseToZero(...tolerance) but looking at the code I can't see that being the case.

I'm wondering if it's something odd with floats and implicit casting.

I agree with your title, very interesting.

My code combined with your error kind of suggests the following;

if max is zero, then return 0, but if max is some other non zero number that when cast to a decimal ...will result in zero?
so, at least 1 question is, what non zero integer number when cast to a decimal could result in zero? hence your title.

Please leave this open; the error message suggests a guard clause somewhere, possible implicit casting error etc.
Maybe there's something else we've missed so would prefer to leave this open.

I'm sure I can make that particular bit of code safer at the very least.
these progressbars take an absolute hammering, so it's worth making this code bulletproof.

please ping me again in a few days if I've not pushed a hotfix for this.

txs for raising the issue,
Cheers, Alan

[PromoFaux]

but if max is some other non zero number that when cast to a decimal ...will result in zero?

_max is an int, though, so it will only ever be a whole number, right? Even when cast as (decimal), it should be {_max }.0... maybe, so at minimum 1.0

And no worries on timing, like I said, I'm yet to be able to reproduce it so it's clearly an edge case.

[goblinfactory]

floats are sneaky bastards... I blame the floats somewhere .. just havent seen exactly how they did it!
(grin)
I'll take a look in detail in a few days, it's a really interesting bug. ciao, A

[goblinfactory]

I'm labelling this a bug, so that it will get some eyeballs, and will remove with the next patch/fix. (I'm sure we can fix this even if this hardly ever occurs.)