GithubHelp home page GithubHelp logo

Comments (5)

asciimoo avatar asciimoo commented on July 3, 2024

Good point, thanks! We also have to update the examples in the colly repo.

from site.

peterhellberg avatar peterhellberg commented on July 3, 2024

http://go-colly.org/docs/best_practices/debugging/

c := colly.NewCollector()
c.SetDebugger(&debug.LogDebugger{})

This can be replaced by c := colly.NewCollector(colly.Debugger(&debug.LogDebugger{}))

http://go-colly.org/docs/best_practices/crawling/

c := c.NewCollector()

// Reduce maximum response body size to 1M
c.MaxBodySize := 1024 * 1024

// Don't track visited urls automatically
c.AllowURLRevisit = true

This can be replaced by c := c.NewCollector(colly.MaxBodySize(1024 * 1024), colly.AllowURLRevisit())

from site.

peterhellberg avatar peterhellberg commented on July 3, 2024

Maybe we should add option functions for WithTransport, DisableCookies, CookieJar, RequestTimeout, Proxy, ProxyFunc?

from site.

asciimoo avatar asciimoo commented on July 3, 2024

Maybe we should add option functions for WithTransport, DisableCookies, CookieJar, RequestTimeout, Proxy, ProxyFunc?

I don't think that it improves the API that much, but duplicates functionality, so I'd vote on don't add. What do you think?

from site.

asciimoo avatar asciimoo commented on July 3, 2024

Docs are updated: 8635de8 7000956 1a9052f

from site.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.