Comments (12)
It should be as easy as adding background-position: center
to all article thumbnails (in the same class where background-size: cover
is defined, I guess).
background-position: center;
Preview:
from godot-website.
Agreed. Ultimately, this does come down to the images themselves. I do think it would be beneficial to standardize the sizing / formatting of the images put up there, but that potentially is a fair bit of work to go back and update images, if desired. I think this does come back to what the blog submitters want to do, as they are the ones actually entering the image.
However, a general rule that could be created for this would to always format the image so that either it's center or left side (how it currently is) would work as the thumbnail.
Again, I think the best examples of the problem can be seen in this screenshot:
- The GDC meetup is a good example of what should be done (according to current styling), because the image itself is split into 2 sections
- The Summer of Code is a bad example of what should be done, because it cuts off nearly half the image
- The Beta 9 screenshot is an average example, as it's not a major problem showing that part of the game
IMO, the best solution to this would be separating out the blog banner image into a 2 images - a preview image (on the news page), and the banner (on the blog page), and making sure that the preview image is always a square. However, I think it comes back to the fact that the people submitting content are usually developers, not content managers or whatever they might be called to constantly be worrying about the website.
At the end of the day, this might even be a non-issue, but more of a reminder for the formatting of the images.
from godot-website.
My opinion in two points:
- I think people won't like having to make two images to illustrate blog posts. IMHO, it's not worth asking for two image (but if it can be optional, than can be ok)
- I think it is a lot easier to make a picture that works for both situations when the content is centered.
IMHO, centering the image is the way to go for now. Even if in some old pictures will not look right, this will simplify things in the future.
from godot-website.
Solved with a redesign in #468.
from godot-website.
This would be a good change for some banners, but for others, it would appear this has been used as a feature:
However,
This would have to be a change to how it's being used in function, or some edits would have to be made. Perhaps a better solution would be to add a preview image for blog posts? But that does seem like a fair bit of work to backfill images, and the added storage space for the images.
from godot-website.
It wasn't really used as a feature, though you're right it turned out well in those two examples :)
If we change to center, I'll just keep this in mind when picking up banner images to ensure that the cropped version would look decent.
from godot-website.
Another potential solution could be to make the images not take up the full height, allowing them to maintain their original size? However I do assume that it was designed to be a square originally:
The CSS for the images:
element {
background: url('https://godotengine.org/storage/app/uploads/public/5c7/67d/8c6/thumb_667_400x1_0_0_auto.png');
background-position: center;
background-repeat: no-repeat;
background-size: contain;
}
from godot-website.
@MHillier98 I think that doesn't look as good from a visual standpoint, especially if images with different aspect ratios were to be used on the same page.
from godot-website.
In most news sites (coming from someone who worked at an online news publication at one point) the way this is done is by creating several different crops per image that are used wherever appropriate.
Like, a small thumbnail (square), a 16x9, a banner at the top of the article, and something for the news banner on the front page. These crops can actually be different images altogether, in the event that there isn't an appropriate thumbnail size, such as the above text-heavy images.
from godot-website.
@jcs224 While this is the best-looking solution, it also requires additional work (see @groud's comment above).
from godot-website.
Please assign me this issue under hacktoberfest. , if it is still open.
from godot-website.
Please assign me this issue under hacktoberfest. , if it is still open.
@ampsteric We will opt-in repository-wide if we decide to participate this year, so please stop spamming.
from godot-website.
Related Issues (20)
- One-time Donation Link HOT 2
- Matrix Community links to https://matrix.to/#/#godot:feneas.org but https://www.feneas.org/ says "The domain name feneas.org Is for sale!" HOT 1
- Download button on Godot Fund Navbar leads to Windows version instead of host platform HOT 5
- "Godot 3 also supports glTF 2.0 and OBJ" on Download pages HOT 2
- Can I try improve website's (at least for home page) UI HOT 3
- Fund Credits: Some sponsor images are cut off on iPhone HOT 1
- Fund credits: Images sometimes donβt show on iPhone HOT 1
- Change references to the "Twitter" to "X" HOT 1
- https://ask.godotengine.org/ returns 404 HOT 2
- Unable to download Godot 1.0 HOT 4
- Download page from fund.godotengine.org directs to Windows HOT 2
- Request: Add the default themes to the forum HOT 2
- Link on Godot download page to troubleshooting page in manual is broken HOT 3
- C# MySqlConnector error on connection HOT 2
- Add ARM-binaries downloads to the Linux Download Page HOT 1
- User groups missing on the map
- Link to Linux desktop integration instructions HOT 3
- Internationalize the website HOT 1
- Include Link List on Community Page HOT 1
- WebP is not PNG HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot-website.