OTel: add method to span name about contrib

[WLun001]

@morigs I think do not need to set method name to span name, as the attributes already set. It works fine with Tracing service

[morigs]

@WLun001 on your screenshot, there is method name in span name. Is it from the instrumentation from this repo? Because I cannot find where it adds method to span name

[WLun001]

the method name adds from here, not from span name

contrib/otelfiber/fiber.go

Line 57 in 97ea1c0

semconv.HTTPMethodKey.String(c.Method()),

[morigs]

What tracing tool do you use? For example, Jaeger groups all spans in "operations" by span names. This means that all spans with name "/users/id" will be in one operation, even if they have different attributes. This is confusing and complicates search

[WLun001]

I am testing with https://uptrace.dev/, could you share your screenshot with Jaeger? I never use it before

[morigs]

@WLun001 In Jaeger it looks like this. As you can see, there is no method in operation name. So all paths with different methods are grouped together

[WLun001]

@morigs I think we can do something like this to allow custom format. What do you think?

https://github.com/open-telemetry/opentelemetry-go-contrib/blob/7e31ebe040306aee2c826972269f938f9f0e7c34/instrumentation/net/http/otelhttp/config.go#L175

[morigs]

@WLun001 sounds good. However, I think that span name should include method name by default, because Jaeger is very popular and other tracing systems works similarly.
Span name should specific enough to identify specific operation. OpenTelemetry semantic conventions mention this as a best practice.

[WLun001]

@morigs not sure if we should do that. If you look at current implementation, they did not include method name
https://github.com/open-telemetry/opentelemetry-go-contrib/tree/7e31ebe040306aee2c826972269f938f9f0e7c34/instrumentation

[morigs]

@WLun001
Not really. otelhttp.NewHandler accepts user-specified name of the span through operation parameter. So it's up to the user to specify a name that specific enough to identify the handler.
For example, I can use it this way: otelhttp.NewHandler(postHandler, "create-enitity") and otelhttp.NewHandler(deleteHandler, "delete-enitity").
However, gofiber instrumentation doesn't require operation name, it sets the name to the route path by default, what causes problems.
Spec describes recommended span names. Example from spec: get_account, not just account.
I understand your point, just making my point clear. If you think that custom formatter will be enough, well, OK. That solves the problem, that's what matters.