Comments (5)
It is indeed a better fit for lint than vet.
I'm not sure about your first four (comparing against true/false). It's true that they are equivalent, but code can carry semantic emphasis by doing that, so I'm wary of flagging them as wrong.
The remainder, now that I think about it, might match vet better. Though they are not incorrect code, they may be accidentally hiding code, and flagging them there probably makes sense in the same way that flagging unreachable code makes sense. I wonder what Rob thinks about that idea.
from lint.
I'm not sure about your first four (comparing against true/false). It's true that they are equivalent, but code can carry semantic emphasis by doing that, so I'm wary of flagging them as wrong.
Do you have an example handy?
Flipping through instances from the corpus, comparing against true/false appears to be a habit of the developer, rather than being reserved for emphasis.
The remainder, now that I think about it, might match vet better. Though they are not incorrect code, they may be accidentally hiding code, and flagging them there probably makes sense in the same way that flagging unreachable code makes sense.
That was the theory I held when I wrote it as a vet check, but it didn't survive first contact. I did some sampling, and I did not find any flagged code that was clearly buggy. I found lots of code that I didn't understand -- and which thus might have been buggy -- but nothing obviously incorrect.
I'd prefer to be wrong about this though, so feel free to push on it. :)
from lint.
On 28 June 2014 01:53, Josh Bleecher Snyder [email protected] wrote:
Do you have an example handy?
I don't have an example handy, but it reminds me of test code for
functions that return a bool, and sometimes I find it clearer to write
if foo(tt.in) == false
. I don't think that's necessarily that much
worse than if !foo(tt.in)
to warrant warning people about it.
That was the theory I held when I wrote it as a vet check, but it didn't survive first contact. I did some sampling, and I did not find any flagged code that was clearly buggy. I found lots of code that I didn't understand -- and which thus might have been buggy -- but nothing obviously incorrect.
I'd prefer to be wrong about this though, so feel free to push on it. :)
If it empirically doesn't find any bad code, or very little bad code,
we should probably just drop it.
from lint.
Sounds right. Dropped! Thanks for the helpful discussion.
from lint.
m
from lint.
Related Issues (20)
- Check for inconsistent receiver types HOT 1
- Receiver Name Consistency HOT 2
- Reopen issue #89 HOT 8
- Disable a block of variables HOT 2
- -set_exit_status has encouraged projects to use the linter in automation HOT 2
- zsh: command not found: golint HOT 6
- Disable specific golint checks/failure in a particular file or across files. HOT 1
- Special case "third_party" as an allowed package name with underscores by convention. HOT 1
- Warn on exported field with unexported type HOT 1
- What does min-confidence mean? HOT 1
- golint seems unable to recognise constants which are typed-iota values with the comment at the end of the line HOT 7
- go:embed gives false positives about comment format HOT 1
- Is this project dead? HOT 1
- Official docker image HOT 1
- module declares its path as: golang.org/x/lint but was required as: github.com/golang/lint HOT 1
- Lint recognizes that the ”Id“ is in the wrong format
- Proposal: blank imports of the embed package should not be lint errors HOT 3
- I can find a way to custom(disable) lint rules HOT 1
- Add a lint to check for self defined type for variables. HOT 1
- no allowance for block comments HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lint.