Array of alternating values to a Struct/Map about redigo

[garyburd]

See http://godoc.org/github.com/garyburd/redigo/redis#example-Scan

for len(values) > 0 {
    var destruct desttype
    values, err = redis.Scan(values, &deststruct.id, &deststruct.title)
    if err != nil {
         // handle error
    }
}

[sinni800]

Is there a possibility this could work if multiple results were returned form SORT? If sort returns

"1Value1", "1Value2", "2Value1", "2Value2" ,"3Value1", "3Value2"

for example? Currenlty I work with a for like this:

for x := 0; x < len(values)/2; x++ {
    p := desttype{}
    p.Id = values[x*3+0]
    p.Title =values[x*3+1]
    retslice = append(retslice, p)
}

[garyburd]

My loop above works with multiple results. Here's an update to the code showing how to fill in retSlice

 var retSlice []desttype
 for len(values) > 0 {
    var p desttype
    values, err = redis.Scan(values, &p.Id, &p.Title)
    if err != nil {
         // handle error
   }
   retslice = append(retslice, p)
}

It's possible to create a function ScanStructSlice:

var p []desttype
err := ScanStructSlice(values, &p, "Id", "Title")

This function will use reflection where it's not otherwise needed.

[sinni800]

Sorry that I completely overread that it scans multiple results.

I don't know what the performance hit of reflect is, so would that method be a huge performance hit? It would certainly make code with lots of Redis SORTs smaller.

Would it also be possible to call into maps this way? You can't get pointers of map values so scan doesn't work for this. It would only be helpful for mockups though, because usually you use a real struct.

ScanStruct would benefit from being able to call into maps though, because it would allow Redis HASHes which have varying keys. Using ScanStruct with maps currently panics.

[garyburd]

I added http://godoc.org/github.com/garyburd/redigo/redis#ScanSlice.

I did not add support for maps. Sketching out code with a map is not any easier than just using a struct. If the keys are unknown, then the application can construct a map using a for loop, map assignment and the Int, String, Bytes and Float64 functions as appropriate.

ScanStruct should return an error for maps. Were you using fe36254 or later?

[sinni800]

Thank you for the addition, it really helped shorting my code.

My code with ScanStruct with a map used a redigo revision older than the one you linked.