Comments (4)
Interesting, thanks for reaching out!
Let me see what the timeline would be to fix this in core jax itself
Just a note:
if you use Python's type checking or if you are using an IDE like PyCharm that supports Python type checking,
passing an int
to adam
would actually raise an error without even having to run the code
Since we explicitly type both the b1
and b2
arguments as float
.
def scale_by_adam(b1: float = 0.9,
b2: float = 0.999,
eps: float = 1e-8,
eps_root: float = 0.0) -> GradientTransformation:
from optax.
A fix should have gone in in JAX
from optax.
Thanks for following up. Yea, I absolutely agree on the use of type checking, though it would be unfortunate if correctness relied on opting in to third party tooling, and in a case where assuming promotion semantics fails in a fairly subtle way. In any case, great that the fix came in so fast!
from optax.
Yep indeed they were quite quick!
Closing the issue since this should now be fixed
from optax.
Related Issues (20)
- Failure when running tests (due to new jax release?) HOT 2
- Documentation for cosine decay schedule HOT 2
- unitwise_norm fails for 3D convolutions HOT 1
- Implement Schedule-Free Learning HOT 1
- "masked" leads to unexpected behavior with callable Pytrees HOT 6
- Passing arguments to train multiple models in parallel HOT 4
- README: deadlink to "Optax 101" notebook HOT 2
- Add a `nesterov` flag to `radam` optimizer HOT 2
- Add an assignment problem solver
- Jaxopt vs Optax HOT 3
- LinearSolveTest.test_solve_sparse fails with jax 0.4.26 HOT 1
- How to Cleanly Specify Optimizer, Schedule, & Gradient Clipping with inject_hyperparams HOT 3
- Add ACProp HOT 1
- Intended usage of the Sophia optimiser HOT 7
- Memory leak in optax.radam HOT 2
- Timeline for JaxOpt migration HOT 11
- AttributeError: module 'optax' has no attribute 'lbfgs' HOT 2
- Performance issue: multi_transform and set_to_zero don't prevent computation HOT 1
- Support for CSR format sparse matrix in optimizer? HOT 1
- Loose dependency allows chex version without 'warn_deprecated_function' to be installed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from optax.