compatibility with google-fhir about fhir-py

[rbrush]

We have worked on some FHIRPath evaluation logic in Python here, but looking at what has been synced from our internal repo to GitHub, I see that the FHIRPath tests aren't there yet. I'll take a look and see if we can sync the tests to ensure FHIRPath is working properly, which would be a good example of how to use it as well. I'll try to get back to this in the next couple days.

[rbrush]

Hi Heming,

For some background, the Python package structure in the previous "fhir" project was an artifact of internal structure and bazel-based builds that was unwieldy -- partly with the symptom that both "google" and "proto" show up twice in the package name, and it does a poor job of following Python conventions. So we ended up reorganizing the code into a much more Pythonic structure that will (hopefully) be easier to use going forward.

Unfortunately that does mean we needed to change the package location. The protocol buffers in both locations should still be wire-compatible though, so any data you might have persisted or transmitted in protobuf form in the previous code should be readable in the new one.

Not being familiar with your code base it's hard to give concrete guidance on pulling in an object that was moved to a new location, but if there are components/submodules that could basically do a find/replace to pull in the new protobuf location and apply the change in a single commit, then that might be the best approach to explore.

Apologies for the noise here; we had pushed this as pre-1.0 code so such changes were possible, but now that we have these in a more idiomatic location I think the structure should be stable.

[Hotrank]

thank you for your response. I think we will need some way to hack our proto generation to get this working.

Now a separate question: I see fhirpath is implemented in this package as well, does this package provide a way to evaluate a fhir proto against a fhirpath expression with this package? If so, what's the proper way of doing it?

[rbrush]

We chatted offline, but for anyone else following along some FHIRPath examples over protocol buffers are here: https://github.com/google/fhir-py/blob/main/google-fhir-r4/README.md#fhirpath-support

[Hotrank]

Thanks very much for your help Ryan! Closing this issue now.