GithubHelp home page GithubHelp logo

Outdated 'Open Sans' in repo about fonts HOT 7 CLOSED

google avatar google commented on July 20, 2024
Outdated 'Open Sans' in repo

from fonts.

Comments (7)

rsheeter avatar rsheeter commented on July 20, 2024

Last modified can also mean adjustments outside the font file that impact what ends up getting served on Google Fonts. I did a quick check on OpenSans-Regular.ttf and it appears to me the one here should be the latest copy.

from fonts.

eins78 avatar eins78 commented on July 20, 2024

@rsheeter I am pretty sure that the font itself was changed, because we are testing the visual output of our styleguide (using Open Sans) by comparing screenshots. This test broke exactly on that 'lastModifed' date…
(Looking at the diffs revealed that kerning of the font changed, if that is of any help).

from fonts.

rsheeter avatar rsheeter commented on July 20, 2024

Can you see for which glyphs kerning shifted? Also on which browser(s)?

It is possible that serving optimizations might have had an impact.

from fonts.

olsonpm avatar olsonpm commented on July 20, 2024

wouldn't a file diff between the font served from google fonts and the github repo solve the issue of what changed?

from fonts.

davelab6 avatar davelab6 commented on July 20, 2024

There are other problems with Open Sans that I will look into

attachment-1

  • Hinting of the tilde ~ is too strong at 13px (and perhaps other sizes) so that it looks flat, like a minus -:

screen shot 2015-08-25 at 15 24 03

Open Sans has a bug in the Romanian 'locl' implementation. Normally S Cedilla (Ş) and T Cedilla (Ţ) should be replaced by S Comma Below (Ș) and T Comma Below (Ț). Unfortunately "Open Sans" does this the way around, Ș and Ț are replaced by Ş and Ţ. Firefox is hit by this bug, see the following bug reports: OpenSans font shows cedillas instead of commas (Şş instead of Șș) for Romanian language (bug in OpenSans font) https://bugzilla.mozilla.org/show_bug.cgi?id=907793 [ro] "Open Sans" font rendered incorrectly https://bugzilla.mozilla.org/show_bug.cgi?id=951141

from fonts.

laerm0 avatar laerm0 commented on July 20, 2024

Naming flaws are solved with @m4rc1e's hotfix, but the tilde problem is still outstanding (#1199) and the Romanian problem is still outstanding (#213). As both of these problem have stand-alone issues, I think we can close this issue. Thoughts, @davelab6?

from fonts.

davelab6 avatar davelab6 commented on July 20, 2024

Sounds good

from fonts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.