GithubHelp home page GithubHelp logo

add EquateString to cmpopts about go-cmp HOT 1 CLOSED

google avatar google commented on August 19, 2024
add EquateString to cmpopts

from go-cmp.

Comments (1)

dsnet avatar dsnet commented on August 19, 2024

Thanks for the proposal.

Comparing on the String method is generally considered poor practice since many types do not have documented guarantees of what the String method even means. For example, regexp.Regexp.String does specify that the String method returns source regexp, while reflect.Type.String warns against comparing on the String method. Most types follow the later model where String is intended as human debugging aid and not as a mechanism for semantic interpretation.

Also, a helper function like this will likely overly match on too many types since many types have a String method, leading to this helper option having a high probability of conflicting with another option.

from go-cmp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.