DownloadReleaseAsset breaks with renamed repository about go-github

[gmlewis]

Could this be related to #3043 ?

[dnephin]

I don't think so, no. The two problems, as I understand them, are:

One:

go-github/github/repos_releases.go

Line 390 in 454c1dd

req.Header.Set("Accept", "*/*")

because this API requires application/octet-stream to download the asset. This line should use that as the Accept header, not */*.

Two:

go-github/github/repos_releases.go

Line 370 in 454c1dd

rc, err := s.downloadReleaseAssetFromURL(ctx, followRedirectsClient, loc)

uses followRedirectsClient instead of s.client.client. The documentation could be more clear about when it's not appropriate to use http.DefaultClient (when you're using private repositories).

#3051 (the PR that closed #3043) could be a problem if DownloadReleaseAsset used s.client.client to follow redirects.

[gmlewis]

@dnephin - thanks for the explanation. Since you seem to have a better grasp of this than myself, would you like to put together a PR to solve these issues?