insufficient confidence threshold when identifying a BSD 2-Clause like license about go-licenses

[Bobgy]

Hi @melinath
I can stably reproduce your failure. Not sure why it can pass on your side.

The error message is a bit unclear, it basically means go-licenses didn't find licenses for the two mentioned libraries.

[Bobgy]

I verified this is a confidence threshold problem when identifying the license.

If you add the following flag, it will pass:

$(go env GOPATH)/bin/go-licenses check . --confidence_threshold 0.7

go-licenses is still using google/licenseclassifier v1, if we upgrade to v2, it can get more accurate.

[Bobgy]

The mentioned license text looks like BSD 2-Clause, but the wording is slightly different.

Compare: https://opensource.org/license/bsd-2-clause/ and https://github.com/dnaeon/go-vcr/blob/v3/LICENSE