Comments (3)
@petea what are your thoughts about this?
from googlesignin-ios.
GSI stores sign-in state in the default keychain group. If you have the Keychain Sharing capability enabled and one or more keychain access groups defined, the default keychain group will be the first item in this list of keychain access groups. Groups defined after this first group could be used for state sharing between apps without GSI state being present, if that's desired.
from googlesignin-ios.
@petea
In our apps the first keychain access group is the shared one, meaning GSI will store the state in a shared place that will be read and written by all our apps. That's undesired of course.
I can think of several ways to avoid such mistakes in the future:
- Keep the current behavior and explicitly mention this in the README.
- Use a different service for each app based on their bundle ID (Like being done in FB SDK). This will require migration which is not desired I assume.
- Allow to select the keychain storage name (Like being done in MSAL). Might also require migration
What do you think?
from googlesignin-ios.
Related Issues (20)
- Update Changelog
- Merge fac-eap branch into main branch
- No library for this platform was found MacOS HOT 2
- Keep error domain `com.google.GIDSignIn` across the whole library.
- Clean up callback flow for sign-in and verify flow.
- GIDSignIn.sharedInstance.restorePreviousSignIn() sometimes fails to invoke completion handler
- The App crashes when launched via Widget. HOT 1
- Create example of VwG flow in existing "DaysUntilBirthday" sample app.
- Address VwG non-interactive flow (token refresh). HOT 1
- Allow only requesting the oauth scopes that an app needs HOT 3
- Migrate current VwG refresh logic to `GIDGoogleUser`.
- Not Bulding for visionOs HOT 1
- Bump minimum iOS version to 12
- Increment AppCheckCore dependency to 11
- faulty App wants additional access to your Google Account
- faulty "App wants additional access to your Google Account" prompt HOT 7
- When implementing Google Sign-In on iOS, is it possible to indicate in the google account sign-in popup that only email address will be used? HOT 3
- Some google accounts can't login, "500. That's an error." HOT 15
- Offline Access Docs HOT 9
- Alternative to custom URL schemes to prevent OAuth2 impersonation attacks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from googlesignin-ios.