clean up warnings about guice

[gissuebot]

From dsallings on June 06, 2007 01:11:14

The attached patch against 335 cleans all but two warnings in my eclipse
configuration.  The two warnings are actually SuppressWarnings annotations for tokens
eclipse doesn't support.

Note that I did add some SuppressWarnings, but tried to keep them localized to
variable definitions.  That meant I'd take a return with a cast and save it to a
variable first so I could suppress the warnings when I couldn't actually fix the
problems.

I added comments for the suppressions I added except where they were really obvious
(i.e. unused in tests).

I removed a variable from InjectorImpl that was completely unused.  I can rework that
to suppress the unused, but it's otherwise dead code.

All the tests still pass, but I hope nobody takes my word for it.

Attachment: gist
   guice-warning-cleanup-335.diff

[gissuebot]

From kevinb9n on June 06, 2007 07:40:01

I'm speechless!  Thanks!

[gissuebot]

From dsallings on August 08, 2007 19:19:19

I'm tracking this in hg with mq here: http://hg.west.spy.net/hg/hacks/guice/

Attachment: gist
   guice-warning-cleanup-345.diff

[gissuebot]

From crazyboblee on September 09, 2007 13:22:43

Thanks for the help, dsallings. I basically rewrote InjectorImpl to be
binding-oriented rather than InternalFactory oriented, and it made the typing a lot
easier to reason about.

Status: Fixed