GithubHelp home page GithubHelp logo

Comments (6)

mungler avatar mungler commented on June 26, 2024 2

In fact, Xcode 15 does not require it to be codesigned, the problem is that the codesigning utility (/usr/bin/codesign) does not consider the package valid enough to even check the current code-signing status. If you delete Versions and move the headers as you say, Xcode will be happy, even without signing it. @tomball advised recently that he does not have an appropriate Google signing identity to sign the frameworks at this stage, so unsigned is the way to go.

My PR changed the structure of the XCFramework artefacts so that /usr/bin/codesign considers them valid, and the new one by @adil-hussain-84 corrects the structure to be in the format Apple specify.

In short - it it not necessary (and also not currently possible) to make a change to have the frameworks codesigned. You are free to codesign the artefacts yourself, but it doesn't really give you any benefit.

from j2objc.

mungler avatar mungler commented on June 26, 2024 1

To be honest, I wondered about this when making the change documented in #2175

I didn't make the change as our application seemed to work happily with the new XCFramework, but this definitely seems more 'correct'.

from j2objc.

mungler avatar mungler commented on June 26, 2024 1

@tomball @adil-hussain-84 PR approved :)

from j2objc.

tomball avatar tomball commented on June 26, 2024

@mungler: please review @adil-hussain-84's PR #2181, since the two of you have become our domain experts on this topic. :-)

from j2objc.

mungler avatar mungler commented on June 26, 2024

Haha, thanks @tomball will do that now

from j2objc.

hohteri avatar hohteri commented on June 26, 2024

Hey, was about to write to the discussions group but while you are at it, would you mind code signing the xcframework? Xcode 15 requires xcframeworks to be code signed. I just manually did that and had to delete Versions and Headers and copy Versions/A/Headers under each build variant and add HeaderPath to all AvailableLibraries in Info.plist. Basically what -headers option does.

I used the following command to code sign the xcframework:
codesign --timestamp -s "Apple Development" ~/j2objc/dist/frameworks/JRE.xcframework

from j2objc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.