GithubHelp home page GithubHelp logo

Improve our linter about mathsteps HOT 7 CLOSED

google avatar google commented on July 24, 2024
Improve our linter

from mathsteps.

Comments (7)

evykassirer avatar evykassirer commented on July 24, 2024 2

oh! I didn't realize it's strict by default. Let's get rid of "use strict"; in those files then. Thanks :D

from mathsteps.

biyasbasak avatar biyasbasak commented on July 24, 2024

I am working on this

from mathsteps.

evykassirer avatar evykassirer commented on July 24, 2024

woo! thanks @biyasbasak

this is going to be so helpful

from mathsteps.

Raibaz avatar Raibaz commented on July 24, 2024

Is it still open and assignable? I can add the missing rules if needed.

from mathsteps.

evykassirer avatar evykassirer commented on July 24, 2024

yes please! thank you :)

from mathsteps.

Raibaz avatar Raibaz commented on July 24, 2024

I opened PR #107 about this, but I have some doubts about the 'use strict' line: if I enable the strict rule, linting gives errors on almost every file since use strict' is unnecessary inside of modules, since ES6 modules are strict by default.

How do you think we should handle this?

from mathsteps.

evykassirer avatar evykassirer commented on July 24, 2024

done!! until we find more rules we want to add haha.

but let's close this for now :)

thanks so much @biyasbasak and @Raibaz for making the mode more beautiful 😍

from mathsteps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.