GithubHelp home page GithubHelp logo

Comments (7)

hmaurer avatar hmaurer commented on July 24, 2024

For the former, it is because "default parameters" in Javascript (an ES6 feature) were not enabled by default before node 6.0.0 (I think). So you need to be running at least node 6.

For the latter, what is the content of test.js? It does not seem to be a file at the root of the repository; did you create it?

from mathsteps.

hmaurer avatar hmaurer commented on July 24, 2024

Ah nevermind, I guess you copied the example script from the README into a test.js file. As far as I can tell there is either a mistake in the example or in the codebase. The property oldNode is null in the first step, however it is present in all the substeps. @evykassirer

from mathsteps.

hmaurer avatar hmaurer commented on July 24, 2024

After taking a look it seems it's due to some weirdness with Status.reset. When calling nodeStatus.reset() here it sets the oldNode property of the object that has just been pushed to steps to null.

I suspect this bug was not present at the time of this commit because it was manually cloning the node status. This might explain why the example does not reflect what's actually going on :-)

from mathsteps.

evykassirer avatar evykassirer commented on July 24, 2024
  1. Yeah, you need at least node 6 for default parameters. I'll open an issue to add that to the documentation.

  2. Okay yeah that's our fault. You have it installed correctly. We'll fix that bug and release a new version on npm and close this issue only once that's fixed

Thanks so much @kovzol for bringing both these issues up and @hmaurer for investigating 😄

from mathsteps.

kovzol avatar kovzol commented on July 24, 2024

Thank you for the prompt reply!

from mathsteps.

evykassirer avatar evykassirer commented on July 24, 2024

(fix made, reopening until I publish a new version of npm)

from mathsteps.

evykassirer avatar evykassirer commented on July 24, 2024

should be fixed now! please re-open this issue if you have any further problems with this.

thanks again for letting us know and @hmaurer and @Raibaz for fixing 😄

from mathsteps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.