Request for comment: Introduce UserData struct in a rule about nftables

[stapelberg]

As per https://sourcegraph.com/github.com/google/nftables@master/-/blob/rule.go#L34:2&tab=references, your nftableslib is the only public user of RuleID currently.

Hence, I think we don’t need to jump through hoops to preserve compatibility, and can favor a cleaner design, where RuleID is dropped entirely and the caller persists the RuleID in UserData if desired.

Does that work?

[sbezverk]

Thank you for your feedback. Unfortunately no, I do use SecureID inside nftableslib just at the point when rule gets created, it is needed to get newly created rule's handle, and I would not want to use UserData.Data as higher level app, example kube-proxy might use it with some encoding which nftableslib has no visibility or knowledge. As you can see eliminating RuleID completely, poses some major problem for me.

[sbezverk]

After more thorough consideration, I think it will work. I am pushing updated PR with no RuleID.