HttpClient builder - setReadTimeout() missing about tsunami-security-scanner

[maoning]

Hi Dawid,

This was a leftover artifact from my incomplete cleanup, thank you for spotting it. I wanted to collapse all the okhttpclient timeouts into a single timeout "ConnectionTimeout" to keep the API simple so that it is easier for users to configure tsunami as well as easier to switch to a different httpclient in the future. Currently all the timeouts inside okhttpclient are set to the same value as what's defined by the connection timeouts.

tsunami-security-scanner/common/src/main/java/com/google/tsunami/common/net/http/HttpClientModule.java

Line 120 in 65e84d5

.callTimeout(Duration.ofSeconds(connectTimeoutSeconds))

            .callTimeout(Duration.ofSeconds(connectTimeoutSeconds))
            .connectTimeout(Duration.ofSeconds(connectTimeoutSeconds))
            .readTimeout(Duration.ofSeconds(connectTimeoutSeconds))
            .writeTimeout(Duration.ofSeconds(connectTimeoutSeconds))

We currently set the timeout to 180s for production tsunami runs.

Let me know if you think there's a strong reason to make different types of timeout configurable as a tsunami user. Otherwise I will remove the Read & Write timeout options from tsunami cli, and only keep the connection timeout option to remove the confusion.