Comments (3)
For the first one, see if SPLIT_COMPLEX_COMPREHENSION might help. (I think it will still split after the k: v
part though.) As for the second example, you might try adjusting SPLIT_PENALTY_AFTER_OPENING_BRACKET. However, it may have other side effects.
from yapf.
Thanks for the suggestions!
Example 1
With split_complex_comprehension = true
, it generates:
donated = {
k: v
for k, v in very_long_dict_name.items()
if k not in self.copy_keys}
I think this looks better. Not ideal, but I assume having a line balancing heuristic (i.e. avoiding very short lines) might be too tricky to consider?
Example 2
I tried different values of split_penalty_after_opening_bracket
(default is 300, I tried 1, 100, 1000, 10000). None of those changed the generated output. I think it's probably because both breakpoints (the first one YAPF chooses and the second one that would be desired) are after an opening brackets, so the penalty would be the same either way?
Perhaps the current penalty system would already make it feasible to achieve the desired balancing behavior by adding a small penalty for based on line shortness (i.e. 79 minus line length, summed over all lines in the formatted expression)?
from yapf.
@bwendling @Spitfire1900 Is this something you might be able to look into?
from yapf.
Related Issues (20)
- Remove the blank line between docstring and function head
- Improve error reporting when `yapf` encounters unsupported Python syntax
- Set specific options for keywords
- Function call without arguments.
- Yapf not formatting python generic
- dedent_closing_brackets not working for Annotations[]
- yapf is failing `pre-commit` with `tool.yapfignore` configured: `yapf: input filenames did not match any python files`
- [BUG] yapf with split_all_top_level_comma_separated_values set to true fails to split lines with tuple LHS HOT 1
- [Bug] [Crash][Reproducible] `EOFError: Ran out of input` when import yapf with multiprocess
- assert formatting
- Strange inconsistent behaviour HOT 3
- Is there a each_dict_entry_on_separate_line for lists? HOT 2
- Try to keep list literals in tuples aligned
- yapf-diff inconsistent with yapf on multiline strings with backslashes
- Ternary conditionals within F Strings Raise IndexError
- Split type hints with trailing comma
- yapf adds spaces before backslash with every run
- Split first and only argument into separate line
- The formatter fails in this file
- Is there a way to `ALLOW_MULTILINE_LISTS`? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yapf.