Comments (11)
Could you check the fix proposal?
npm i [email protected]
from zx.
Works like a charm on my side. Thank you! 🍺
from zx.
@antonmedv same, works fine, thanks!
from zx.
Ouch, we should make detached
option configuralble.
https://nodejs.org/api/child_process.html#optionsdetached
from zx.
@antongolub my platform is linux
, will it work fine by default or do I need to specify detached=? Zx version 7 works fine
from zx.
Well, the only purpose for setting detached=true
by default is to make $`sleep 999`
abortable.
nodejs/node#37518
@antonmedv, what do you think?
from zx.
I did not get this. We want to make detached=true by default?
from zx.
v7 uses false
v8 uses true
to handle abort controller's corner case.
@antonmedv, Is this a some kind of sensible defaults? should we rollback the value?
from zx.
Yes, I don't think we should detach process.
to handle abort controller's corner case.
What corner case?
from zx.
corner case?
Technically, detached + abort() kills the starter process (bash) only.
from zx.
Hi there,
I've got the same issue. What do I need to do in v8 to make CTRL+C
kill the child process?
from zx.
Related Issues (20)
- Feature request: Process Promise verbose() HOT 1
- Self-introduction: GitHub Action `run-zx`
- Reduce package installation size HOT 3
- Feature request: nothrow() only for a subset of error codes
- Allow multiple lines of hashbangs
- $`readlink` always throws error HOT 2
- An easy way to specify stdin HOT 3
- Replacing globby with a lighter alternative HOT 3
- Problem with Nested double quote and single quote command
- Windows: Create process not expected to return HOT 6
- feat request: provide formatters shortcuts
- feat req: provide `signal` opt
- Setting stdio/err to inherit throws error HOT 1
- Typo in 8.0 release description HOT 1
- Feature request: automatically add a newline after commands that don't end their output with one HOT 4
- The type for `glob` is `any` after 8.0.0 HOT 5
- Feature request: add `usePwsh` helper for PowerShell 7+ HOT 3
- Why zx instead of Python ? HOT 2
- Markdown script didn't work for CRLF file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zx.