GithubHelp home page GithubHelp logo

Comments (3)

chingor13 avatar chingor13 commented on July 18, 2024

I suggest we do (1) and (2).

We should encourage people who are explicitly trying to access the AccessToken to do something like:

GoogleCredentials credentials = GoogleCredentials.getApplicationDefault();
AccessToken token = credentials.refreshAccessToken();
// OR
credentials.refresh();
AccessToken token = credentials.getAccessToken();

For (3), there are a few issues:

  • OAuth2Credentials#getAccessToken() would need to either add throws IOException or try to refresh and then silently swallow any exceptions.
  • For any swallowed exception, you will miss out on the contents of the exception and not realize that we are potentially making extra auth requests
  • Anyone who is currently using getAccessToken() does not expect to be making IO calls. This is a behavior change and will break downstream users.

from google-auth-library-java.

chingor13 avatar chingor13 commented on July 18, 2024

Adding a refreshIfExpired() that smartly refreshes a possibly expired token would make the way to do this:

GoogleCredentials credentials = GoogleCredentials.getApplicationDefault();
credentials.refreshIfExpired();
AccessToken token = credentials.getAccessToken();

This should be easier to reason about then calling credentials.getRequestMetadata(uri) which is what the client libraries call before each request (which will load or refresh the credentials if necessary).

from google-auth-library-java.

chingor13 avatar chingor13 commented on July 18, 2024

Next release will contain this method and updated documentation.

from google-auth-library-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.