Comments (5)
One thing that's not clear to me from HttpServiceOptions is why it's necessary to have two layers of indirection, i.e. httpTransportFactoryClassName => httpTransportFactory => HttpTransport.
from google-auth-library-java.
HttpTransport
implementations might have instance fields (see for instance NetHttpTransport.Builder
). So while you could serialize them just using the class name and a no-arg constructor the deserialized transport could have have a different behavior (e.g. missing a proxy configuration).
We introduce an HttpTransportFactory
and document that it should have a no-arg costructor so we can serialize it just using only the classname. To HttpTransportFactory
we can add proper documentation and it's reasonable to assume/require that a factory has no instance fields and an empty constructor.
from google-auth-library-java.
Ok, that makes sense. This seems like a reasonable approach and I'm personally fine with using it here (google-auth-library-java).
from google-auth-library-java.
I agree with adding this functionality to Credentials so that it can be used more broadly. There was no decision when this was originally created inconsistent with this.
from google-auth-library-java.
This was fixed in #69
from google-auth-library-java.
Related Issues (20)
- External Cloud RAD Pages are outdated and show v1.7.0 as the latest release
- Integrating google-auth-library-java into OSS-Fuzz HOT 1
- Warning: a recent release failed
- Support for GCP Application Default Credentials strategy HOT 1
- Add support for reading GOOGLE_APPLICATION_CREDENTIALS as a property HOT 1
- Missing scopes using WIF when upgrading google-auth-library-java-oauth2-http from 1.13.0 to 1.14.0 HOT 8
- google-auth-library-java-oauth2-http: refresh() doesn't generate new token on each call in GKE HOT 5
- Add reactor Bindings HOT 3
- The horror of chain reaction (GoogleCredentials) HOT 1
- Allow usage of ExternalAccountCredentials custom implementation HOT 2
- unchecked casts are bad practice, but allowed globally in pom.xml
- Add native image support for credentials and appengine modules
- impersonated_service_account not recognized HOT 1
- ExternalAccountCredentials serialization is broken HOT 1
- com.google.firebase.messaging.FirebaseMessagingException: Unknown error while making a remote service call: Error getting access token for service account: Unable to tunnel through proxy. Proxy returns "HTTP/1.1 405 Method Not Allowed", HOT 2
- [kms]: Missing credentials leads to misleading exception and pointless retry loop HOT 4
- DefaultPKCEProvider challenge rejected HOT 4
- Method implementation and logic isOnGAEStandard7() is incorrect for java21 jetty which does not define the old jetty logging class. HOT 2
- External documentation is outdated - latest published version is 1.20.0 HOT 1
- AppEngineCredential depends on legacy bundled service HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-auth-library-java.