samples.snippets.v3.alerts-client.snippets_test: test_list_alert_policies failed about python-monitoring

[flaky-bot]

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

---

When run at the same commit (e6063de), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

[dandhlee]

hey @arithmetic1728 , similar to #150 it seems like there is also a discrepancy between pochan.alert_policy.display_name from the test and [(policy.name, policy.display_name) for policy in policies] from the client seems to differ from time to time, causing these flaky tests. Please help take a look!

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: cd1300d
buildURL: Build Status, Sponge
status: failed

Test output

capsys = <_pytest.capture.CaptureFixture object at 0x7f777e2f0e80>
pochan = 
def test_list_alert_policies(capsys, pochan):
    snippets.list_alert_policies(pochan.project_name)
    out, _ = capsys.readouterr()
    # Only check up to the first 20 characters of the display name
    # as long strings printed to the console are truncated.


  assert pochan.alert_policy.display_name[0:20] in out


E       AssertionError: assert 'snippets-test-mokaqz' in 'name                                                                        display_name\n---------------------------...est-tigjdnakwf\nprojects/python-docs-samples-tests-py36/alertPolicies/7501165308929258283   snippets-test-beidgwacze\n'
snippets_test.py:130: AssertionError

[parthea]

I was only able to re-create this issue by modifying test_list_alert_policies() to list a newly created alert policy.

def test_list_alert_policies(capsys, pochan):

    # Create a new alert policy
    json = open("test_alert_policy.json").read()
    policy = monitoring_v3.AlertPolicy.from_json(json)
    policy.display_name = "snippets-test-" + random_name(10)
    pochan.alert_policy = pochan.alert_policy_client.create_alert_policy(
                name=pochan.project_name, alert_policy=policy
            )

    # List alert policies and look for the policy we just created
    snippets.list_alert_policies(pochan.project_name)
    out, _ = capsys.readouterr()
    # Only check up to the first 20 characters of the display name
    # as long strings printed to the console are truncated.
    assert pochan.alert_policy.display_name[0:20] in out

The above test fails locally. Adding a retry fixed the issue. See below:

def test_list_alert_policies(capsys, pochan):
    # Create a new alert policy
    json = open("test_alert_policy.json").read()
    policy = monitoring_v3.AlertPolicy.from_json(json)
    policy.display_name = "snippets-test-" + random_name(10)
    pochan.alert_policy = pochan.alert_policy_client.create_alert_policy(
                name=pochan.project_name, alert_policy=policy
            )

    # List alert policies and look for the policy we just created.
    # Query snippets.list_alert_policies() for up to 5 seconds
    # to allow the newly created policy to appear in the list.
    retry = 5 
    while retry:        
        snippets.list_alert_policies(pochan.project_name)
        out, _ = capsys.readouterr()
        # Only check up to the first 20 characters of the display name
        # as long strings printed to the console are truncated.
        if pochan.alert_policy.display_name[0:20] in out:
            break
        retry = retry - 1
        time.sleep(1)

    assert retry > 0

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: 064f1e0
buildURL: Build Status, Sponge
status: failed

Test output

capsys = <_pytest.capture.CaptureFixture object at 0x7f2bd54d7b90>
pochan = 
def test_list_alert_policies(capsys, pochan):
    snippets.list_alert_policies(pochan.project_name)
    out, _ = capsys.readouterr()
    # Only check up to the first 20 characters of the display name
    # as long strings printed to the console are truncated.


  assert pochan.alert_policy.display_name[0:20] in out


E       AssertionError: assert 'snippets-test-wcujif' in 'name                                                                        display_name\n---------------------------...est-xvqznroeih\nprojects/python-docs-samples-tests-py37/alertPolicies/2404774893716709115   snippets-test-tofvuduanj\n'
snippets_test.py:130: AssertionError

[flaky-bot]

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.

---

commit: a942b31
buildURL: Build Status, Sponge
status: failed

Test output

capsys = <_pytest.capture.CaptureFixture object at 0x7f50cd227e10>
pochan = 
def test_list_alert_policies(capsys, pochan):
    snippets.list_alert_policies(pochan.project_name)
    out, _ = capsys.readouterr()
    # Only check up to the first 20 characters of the display name
    # as long strings printed to the console are truncated.


  assert pochan.alert_policy.display_name[0:20] in out


E       AssertionError: assert 'snippets-test-xshkan' in 'name                                                                        display_name\n---------------------------...est-tigjdnakwf\nprojects/python-docs-samples-tests-py36/alertPolicies/7501165308929258283   snippets-test-beidgwacze\n'
snippets_test.py:130: AssertionError

[parthea]

This should be resolved with #170