GithubHelp home page GithubHelp logo

Comments (4)

morethanreal avatar morethanreal commented on June 3, 2024

You can listen to the core-overlay-open event on the paper-dialog to get notified when the dialog is opened or closed. event.detail.opened will give you the opened state. I've updated the doc to include this info.

from paper-dialog.

yoavniran avatar yoavniran commented on June 3, 2024

thanks. that did the trick.

I did however notice something that you might call a bug. when core-overlay fires the event for closing in the "openedChanged" handler, when the dialog is closing its doing:

this.fire('core-overlay-open', this.opened);  

with this.opened being false.

the fire function in utils.js is considering the detail as empty and replaces it with an empty object.

var detail = detail || {};

So the event that gets fired has its "detail" property set to: {} instead of false. when this.opened is true I get the correct value. seems like unexpected behavior to me.

thanks,
Yoav

from paper-dialog.

sjmiles avatar sjmiles commented on June 3, 2024

Fwiw, the detail flaw is fixed here googlearchive/polymer-dev@43fe8b9.

from paper-dialog.

yoavniran avatar yoavniran commented on June 3, 2024

cool, thanks

from paper-dialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.