GithubHelp home page GithubHelp logo

Comments (5)

paulirish avatar paulirish commented on June 21, 2024

Hmmm Whats the end result you'd want?

Everyone in your company/team can see your specific additions when they view the rendered report?

from lighthouse-stack-packs.

pedddro avatar pedddro commented on June 21, 2024

Hmmm Whats the end result you'd want?

Everyone in your company/team can see your specific additions when they view the rendered report?

stack packs look easier than fork Lighthouse and create your own recommendations or lighthouse plugins. For example, I will create a stack pack that detects a JS code that loads all js after user interaction which may affect negatively INTP(CWV metric).

Maybe not name it stack pack, but stacks that don't need to be added to Lighthouse; people will be free to create their own recommendations.

from lighthouse-stack-packs.

pedddro avatar pedddro commented on June 21, 2024

I think a more complete idea is to allow community stack packs to be run with flags and we could have more diagnostics for technologies.

An example is Wordpress loads an emoji script(wp-emoji-release.min.js) that many people don't need. A community Wordpress stack pack to remove it can be made, which wouldn't be dependent on the main WP stack pack.

from lighthouse-stack-packs.

connorjclark avatar connorjclark commented on June 21, 2024

Stack packs were designed for this:

  1. Given a detected JS library/framework on the page...
  2. ...augment specified audits with additional strings, where library-specific advice can be given

They aren't designed to do the detection themselves. For that, Lighthouse uses https://github.com/johnmichel/Library-Detector-for-Chrome . There is no mechanism to detect from a stack-pack implementation anything other than what comes from that. It's just a bag of strings.

Given:

For example, I will create a stack pack that detects a JS code that loads all js after user interaction which may affect negatively INTP(CWV metric).

This seems like a custom audit, so we'd point you to Lighthouse plugins.

I think a more complete idea is to allow community stack packs to be run with flags and we could have more diagnostics for technologies.

An example is Wordpress loads an emoji script(wp-emoji-release.min.js) that many people don't need. A community Wordpress stack pack to remove it can be made, which wouldn't be dependent on the main WP stack pack.

Can you explain how this differs from Lighthouse plugins, which can be distributed via npm and work today?

from lighthouse-stack-packs.

pedddro avatar pedddro commented on June 21, 2024

Can you explain how this differs from Lighthouse plugins, which can be distributed via npm and work today?

The difference is implementation, I can create a stack pack with 1 PR, while the plugin seems more than that, also UX-wise as the results will appear in the performance audit.

from lighthouse-stack-packs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.