window.open behavior about carlo

[pavelfeldman]

Fixed, there are multiple windows now.

[pavelfeldman]

What is your use case? Caro assumes that the web content belongs to the actual app, so if won't do window.open on its own. Do you suggest enabling multi-window apps in Carlo?

[nessup]

I'm building a specialized browser, so I'd benefit immensely from Chromium's security patches and new web tech going downstream into my application. To me, this is Carlo's strongest advantage, so much so that I'd forgo the many infrastructure conveniences that electron offers.

When intercepting the targetcreated event from BrowserContext, I'd suggest having a way to assign a BrowserContext to a window or to an iframe. I'm not sure if this is somehow possible with Puppeteer/DevTools, but this would be amazing for Carlo. I've been poring over the Puppeteer documentation for anything that might make that possible.

[nessup]

Correction: assign a Frame to a window or an iframe

[nessup]

OK, for my specific use case with iframes, I may have found a solution. But in general, yes, I think Carlo should provide some interface for multiple windows. App would need to have multiple pages. Not sure what your thoughts are on how a PR about this should be formed given that there's a one-to-one relationship between an App and a page from Puppeteer.

[nessup]

Hi Pavel, awesome!! Thank you so much.

It seems that calls to window.open from within an iframe doesn't trigger targetcreated. Instead, a new Chromium browser window is opened. Any ideas?