Added [app.serveOrigin] UnhandledPromiseRejectionWarning about carlo

[pavelfeldman]

The idea behind serveOrigin is that it is used for dev mode and overrides serveFolder. Carlo should not be used without serveFolder, because it defeats Carlo's purpose. You can run express and point your browser to the port if all you want is serve.

[vsemozhetbyt]

Did you update carlo to the last master state?

[kraciasty]

Yes, it's the latest.

[vsemozhetbyt]

H'm. I have a different issue:

'use strict';

const carlo = require('carlo');

(async function main() {
  try {
    const app = await carlo.launch();
    app.on('exit', () => process.exit());

    app.serveOrigin('https://example.org');

    console.log(app.serveOrigin);

    await app.load('index.html');

    console.log(await app.evaluate(() => location.href));
  } catch (err) {
    console.error(err);
  }
})();

[Function: serveOrigin]
Error: Please call app.serveFolder(__dirname) or point to other folder(s) with your web files
    at App.load (carlo\lib\carlo.js:122:13)
    at main (test.js:14:15)
    at process.internalTickCallback (internal/process/next_tick.js:77:7)

[kraciasty]

My bad,
UnhandledPromiseRejectionWarning with npm 0.9.11
master results are same as yours

[kraciasty]

I got it to launch by adding app.serveFolder('@')

'use strict';

const carlo = require('carlo');

(async function main() {
  try {
    const app = await carlo.launch();
    app.on('exit', () => process.exit());

    app.serveOrigin('https://example.org');
    app.serveFolder('@')

    console.log(app.serveOrigin);

    await app.load('index.html');

    console.log(await app.evaluate(() => location.href));
  } catch (err) {
    console.error(err);
  }
})();

[vsemozhetbyt]

I can also manage with this:

'use strict';

const carlo = require('carlo');

(async function main() {
  try {
    const app = await carlo.launch();
    app.on('exit', () => process.exit());

    app.serveOrigin('https://example.org');
    app.serveFolder('/');
    await app.load('index.html');

    console.log(await app.evaluate(() => location.href));
  } catch (err) {
    console.error(err);
  }
})();

(The location is a bit confusing though: https://domain/index.html)

Maybe doc example needs to be updated with app.serveFolder() added?

[kraciasty]

Perhaps it could be changed in load() ?

load(uri = '') {
  if (!this.www_.size) {
    if (this.wwwOrigin_) {
      this.www_.set('/');
    } else {
      this.page_.close();
      throw new Error('Please call app.serveFolder(__dirname) or point to ' +
                      'other folder(s) with your web files');
    }
  }
  return this.page_.goto(`https://domain/${uri}`, {timeout: 0});
}

And it'd be implicitly set, saving from confusion as mentioned above

app.serveOrigin('https://example.org');
// app.serveFolder('/');
await app.load(); // no URI passed