My TWA is crashing multiple times. about svgomg-twa

[andreban]

Thanks for the feedback, @AlexBorsody

I agree that, as library matures, we'll have less issues and the need to update will become more sparse.

Though, It's fair to say that, once a developer creates an app and uploads to a store, they will need to update it with some frequency. It may be because the minimum target SDK requirement changed or because an underlying library was updated with bug fixes. This is also true with the WebView, as it has its own support library.

In most cases, updating will mean updating the support library version, rebuilding and uploading the new version. Bubblewrap reduces the amount of work needed and provides commands that could, for instance, be integrated into a CI (bubblewrap update and bubblewrap build). Uploading the new version to the store is still manual. We hope to automate that even more in the future.

Moving from the old custom-tabs-client library to android-browser helper does require more steps than the usual. But once the application is moved, updates should be streamlined.

Regarding unknown crashes, we're working on tracking and fixing those - from the ones mentioned on this issue, some may have already been fixed on the android-browser-helper library - that's why we recommend updating. Others, like this one, are harder to reproduce and fix, and seem to be tied to the OS itself, and not to the Trusted Web Activity (meaning that if the app was 100% native or used the WebView, they'd still see the issue).

Any further details on those issues, such as the devices where the issue is happening and how often they happen further help us understand what is causing the crash and prioritize fixing it. If possible, a reproduction case is the best (but, from what I've seen in those crashes, not possible in most cases)

We're working on improving the Running in Chrome toast.

[matthewhartman]

Hey @jitendra1607

Interesting issue. Do you mind pasting the contents of your /app/build.gradle file so I can try and help.

Cheers.

[PEConn]

Hey, I'd recommend using either bubblewrap, which is a command line tool for generating TWAs or the more hands android-browser-helper instead of this project. They're the recommended, up to date way of making TWAs, this project is mostly deprecated (see the top bit of the README). (llama-pack is what bubblewrap used to be called, we should update that.)

[AlexBorsody]

Seems like may be best to stick with WebView, to avoid code updates every few months, unknown crashes and of course the "running in Chrome toast." In addition, sharing the same state as the browser can also be confusing, I don't native device features for now so WebView is probably the best solution until TWAs are better supported. I like the small package size but too many other issues. I look forward to giving this a try again down the line. Thanks for all the hard work so far!

[matthewhartman]

Thanks for all your hard work guys and for the helpful resources. Really appreciate it! 💪

[jitendra1607]

I have a suggestion, till then this TWA thing matures we can have global exception handler to catch all exception. Then this handle should open chrome browser with PWA link. This way users will have working app somehow.

…

On Tue, 26 May, 2020, 19:19 André Cipriani Bandarra, < ***@***.***> wrote: Thanks for the feedback, @AlexBorsody <https://github.com/AlexBorsody> I agree that, as library matures, we'll have less issues and the need to update will become more sparse. Though, It's fair to say that, once a developer creates an app and uploads to a store, they need to update it with some frequency. It may be cause the minimum target SDK requirement changed <https://developer.android.com/distribute/best-practices/develop/target-sdk> or because an underlying library was updated with bug fixes. This is also true with the WebView, as it has its own support library <https://developer.android.com/jetpack/androidx/releases/webkit>. In most cases, updating will mean updating the support library version, rebuilding and uploading the new version. Bubblewrap <https://github.com/GoogleChromeLabs/bubblewrap> reduces the amount of work needed and provides commands that could, for instance, be integrated into a CI (bubblewrap update and bubblewrap build). Uploading the new version to the store is still manual. We hope to automate that even more in the future. Moving from the old custom-tabs-client library to android-browser helper does require more steps than the usual <https://developers.google.com/web/android/trusted-web-activity/android-browser-helper-migration>. But once the application is moved, updates should be streamlined. Regarding unknown crashes, we're working on tracking and fixing those - from the ones mentioned on this issue, some may have already been fixed on the android-browser-helper library - that's why we recommend updating. Others, like this one <https://issuetracker.google.com/issues/62427912>, are harder to reproduce and fix, and seem to be tied to the OS itself, and not to the Trusted Web Activity (meaning that if the app was 100% native or used the WebView, they'd still see the issue). Any further details on those issues, such as the devices where the issue is happening and how often they happen further help us understand what is causing the crash and prioritize fixing it. If possible, a reproduction case is the best (but, from what I've seen in those crashes, not possible in most cases) We're working on improving the Running in Chrome <https://bugs.chromium.org/p/chromium/issues/detail?id=1068106&q=component%3AUI%3EBrowser%3EMobile%3ETrustedWebActivities&can=2> toast. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFJOGSBTN3IG3OLTMSJGFJ3RTPCF7ANCNFSM4MYBCHYA> .

[andreban]

Closing the issue. Please, report an issue on https://github.com/GoogleChrome/android-browser-helper if this still a problem.