Comments (5)
Which files contain the shutdown image tests you referred to?
from compute-image-tools.
You can see all the envolved workflows here image_test/metadata-script/shutdown-script*
from compute-image-tools.
We can ensure step execution order follows a specific order defined in the workflow. This way, "wait logs" would always start before "shutdown".
This ordering can be implicit, based on the ordering of elements in the workflow. Or it could be explicit by introducing another element along "Dependencies".
from compute-image-tools.
We can ensure step execution order follows a specific order defined in the workflow. This way, "wait logs" would always start before "shutdown".
Ok. And what about if we want two steps starting almost concurrently but with one of them starting a bit early? This is the case here. We do not want to make shutdown
depends on wait logs
because if we do that the workflow will never finish (we are waiting for the logs that will be printed when the instance is powered off). And by the documentation, all the steps that do not have dependencies will start immediately, but here seems that immediately does not mean that they will start at the same time, maybe this is why we have faced the described issue. Or they start at the same time but one step takes more time than the other to "get ready". I am not sure, that is why we brought this to discussion.
This ordering can be implicit, based on the ordering of elements in the workflow. Or it could be explicit by introducing another element along "Dependencies".
I did not know about this implicit dependency thingy. How does that work? Maybe this should be described in Workflow Configuration File Specification.
from compute-image-tools.
Implicit ordering is probably something we should implement in the future. The idea is to have Daisy respect the order of steps in Steps and Dependencies section.
For example, if we have:
Steps {
step1:...
step2:...
}
(and no Dependencies section), then step1 should always be started before step2.
If ordering of steps is defined by Dependencies section, we would do the same. For example, if we had following dependencies:
Dependendencies: {
cleanup: [wait-for-logs, shutdown]
}
Then wait-for-logs should always start before shutdown.
This way, we don't have to extend workflow definition schema.
from compute-image-tools.
Related Issues (20)
- Incorrect hostname for VMs with multiple network interfaces
- panic: runtime error: invalid memory address or nil pointer dereference on Ubuntu 20.04
- Issue with bootstrap_install.ps1 HOT 2
- `import_precheck` fails on CentOS 7 HOT 2
- importing process interrupted when `/etc/netplan` contains subdirectory (Ubuntu 18+) HOT 1
- getting error while importing my ubuntu 2004vmdk into compute instance HOT 1
- Execution fails when shielded VMs org policy is enforced HOT 3
- GCE_Export Release Version access_denied HOT 1
- daisy release version has access denied HOT 1
- Should this be more than 1 GB?
- gcloud compute images import does not allow centos-8 in option --os HOT 1
- Compute engine create with container + SSD
- Could not fetch resource
- Semidev1
- Shared VPC issue during build
- Deployments of UBUNTU with "snapd" (google tool use this snapd?) HOT 3
- windows-startup-script-url: Message: Either the Name or Index parameter is required HOT 2
- Workflow update required for windows-10-20h2-ent-x86
- Fix the setting for 'x86_build' and maybe 'uefi_build' on the 'windows-build-bios.wf.json'
- Create custom Windows BYOL images failed HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compute-image-tools.