GithubHelp home page GithubHelp logo

Comments (5)

zoran15 avatar zoran15 commented on July 22, 2024

Which files contain the shutdown image tests you referred to?

from compute-image-tools.

lucaskanashiro avatar lucaskanashiro commented on July 22, 2024

You can see all the envolved workflows here image_test/metadata-script/shutdown-script*

from compute-image-tools.

zoran15 avatar zoran15 commented on July 22, 2024

We can ensure step execution order follows a specific order defined in the workflow. This way, "wait logs" would always start before "shutdown".

This ordering can be implicit, based on the ordering of elements in the workflow. Or it could be explicit by introducing another element along "Dependencies".

from compute-image-tools.

lucaskanashiro avatar lucaskanashiro commented on July 22, 2024

We can ensure step execution order follows a specific order defined in the workflow. This way, "wait logs" would always start before "shutdown".

Ok. And what about if we want two steps starting almost concurrently but with one of them starting a bit early? This is the case here. We do not want to make shutdown depends on wait logs because if we do that the workflow will never finish (we are waiting for the logs that will be printed when the instance is powered off). And by the documentation, all the steps that do not have dependencies will start immediately, but here seems that immediately does not mean that they will start at the same time, maybe this is why we have faced the described issue. Or they start at the same time but one step takes more time than the other to "get ready". I am not sure, that is why we brought this to discussion.

This ordering can be implicit, based on the ordering of elements in the workflow. Or it could be explicit by introducing another element along "Dependencies".

I did not know about this implicit dependency thingy. How does that work? Maybe this should be described in Workflow Configuration File Specification.

from compute-image-tools.

zoran15 avatar zoran15 commented on July 22, 2024

Implicit ordering is probably something we should implement in the future. The idea is to have Daisy respect the order of steps in Steps and Dependencies section.

For example, if we have:
Steps {
step1:...
step2:...
}

(and no Dependencies section), then step1 should always be started before step2.

If ordering of steps is defined by Dependencies section, we would do the same. For example, if we had following dependencies:

Dependendencies: {
cleanup: [wait-for-logs, shutdown]
}

Then wait-for-logs should always start before shutdown.

This way, we don't have to extend workflow definition schema.

from compute-image-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.