GithubHelp home page GithubHelp logo

Comments (3)

ace-n avatar ace-n commented on August 16, 2024

TODO from @grayside:

  1. split up the cloud-run-manager service account into website-identity and api-identity (see #197 and #198)
  2. attach the necessary permissions
  3. revise the deploy instructions/process

from emblem.

ace-n avatar ace-n commented on August 16, 2024

Per @engelke - we should try to create four service accounts.

The first two are separate accounts for the API and website (i.e. what we've done already)

The latter two are used to create ID tokens - one as an Approver, the other as a User.

from emblem.

ace-n avatar ace-n commented on August 16, 2024

I did a quick audit of our Terraform IAM definitions; here are some issues I found.

Pub/Sub access (for automated rollouts)

pubsub_publisher_iam_member grants Pub/Sub publisher access to every Pub/Sub topic. We should explore using google_pubsub_topic_iam_member instead to limit this access to a specific topic.

✨ See #329

Cloud Run Admin (for Cloud Build)

We currently use the roles/run.admin role for the Cloud Build Service Account. I wonder if we can "get away with" a more tightly-scoped role like roles/run.developer. 🤔

🚫 This is not worth implementing.

I'll go ahead and make PRs to fix these. @grayside is there anything else required to land this?

from emblem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.