GithubHelp home page GithubHelp logo

Comments (3)

chmod0775 avatar chmod0775 commented on May 11, 2024 1

@nitobuendia, Most of this stuff is a little pendantic, just a few typos:

Stream video with RTCPeerConnection

  1. pc1 and pc2 should be switched to localPeerConnection and remotePeerConnection, respectively

In this example, the two RTCPeerConnection objects are on the same page: pc1 and pc2. Not much practical use, but good for demonstrating how the APIs work.

  1. s/Connectionpc1/Connection/

Bonus points
..
..
..
4. From the console, look at localPeerConnectionpc1.localDescription. What does SDP format look like?

Thank you for your work.

from webrtc-web.

nitobuendia avatar nitobuendia commented on May 11, 2024

@chmod0775 Thanks a lot for reporting. It feels like we updated the codelab repository to fix some issues; but we may have neglected or forgotten to do the same on the codelab text. I have worked on it for step-01 and step-02 which I presume are the ones that have the biggest differences. Have you encountered major differences in other parts too?

@samdutton I have made the suggested changes and sent it your way.

from webrtc-web.

chmod0775 avatar chmod0775 commented on May 11, 2024

@nitobuendia Yeah, glad to help! I'll run through codelab again this week. If I find anything else, I'll be sure to comment in here.

from webrtc-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.