Configurable Allocator HTTP status codes on failure about agones

[markmandel]

One possible extra wrinkles - it may need to be grpc status codes, such as what you see here:
https://pkg.go.dev/google.golang.org/grpc/codes#pkg-types

See:

https://github.com/grpc-ecosystem/grpc-gateway/blob/b9de2f20010f706d6efd4b726daa2746a017cb37/runtime/errors.go#L36-L77

For the mappings.

[Kalaiselvi84]

Shall I work on this task?

[markmandel]

@Kalaiselvi84 sounds good!

[Kalaiselvi84]

Could you please confirm if the following steps are the correct approach?

1. Add new entry[HTTP_STATUS_UNALLOCATED] under the allocator section in the values.yaml.
   

   agones/install/helm/agones/values.yaml

   Line 186 in 4bb6731

   allocator:

2. Reflect the new env variable in the allocation.yaml.
   

   agones/install/helm/agones/templates/service/allocation.yaml

   Line 247 in 4bb6731

   env:

3. Implement a function to fetch the code from the env variable[HTTP_STATUS_UNALLOCATED] in the converter.go file.

4. Use helm upgrade to deploy the changes.

[markmandel]

Add new entry[HTTP_STATUS_UNALLOCATED] under the allocator section in the values.yaml.

I'm thinking something like:

agones.allocator.service.http.unallocatedStatus ?

Since I think that would be the right nesting and semantic position.

And then yes, that would need to be arg passed into the Allocator Service.

Implement a function to fetch the code from the env variable[HTTP_STATUS_UNALLOCATED] in the converter.go file.

You can extend the existing viper code to do the parsing. By default it should be http code 429 as it is now, if it's not set.

I think we'll have to be clear in the docs, that we are specifying which gRPC status to return. which is defined here (best reference I could find), and shows how gRPC codes are matched to HTTP codes :

https://github.com/googleapis/googleapis/blob/master/google/rpc/code.proto#L32-L185

🤔 there's an interesting question on how we can e2e test this without some kind of custom install. Will need to think on that one.

[markmandel]

Just reopening, as I noticed the PR has no docs 😄

Can we add some docs to the Helm configuration page please?