`make gen-all-sdk-grpc` is ineffective for nodejs about agones

[roberthbailey]

@steven-supersolid might also be able to shed some light on the expected behavior here.

[markmandel]

I thought that node did it's code gen at runtime?

[markmandel]

I thought that node did it's code gen at runtime?

Ignore me - that was the old nodejs.+ grpc.

[lacroixthomas]

It seems to be working fine on my side, from what I've seen, the command used in the description of the issue is make gen-sdk-grpc, which only generate the files for the default SDK_FOLDER=go, but not the node one

To generate the node one you can either run make run-sdk-command COMMAND=gen SDK_FOLDER=node or make gen-all-sdk-grpc to generate them all

I can make an PR to update it to beta if you want though ?

[igooch]

It seems to be working fine on my side, from what I've seen, the command used in the description of the issue is make gen-sdk-grpc, which only generate the files for the default SDK_FOLDER=go, but not the node one

Good catch, typo on my end. I'll update the bug title to make gen-all-sdk-grpc. This should generate for nodejs (and for all "supported" languages in general).

I can make an PR to update it to beta if you want though ?

If you're able to get the make run-sdk-command COMMAND=gen SDK_FOLDER=node to work that would be amazing.

[lacroixthomas]

It seems to be working fine on my side, from what I've seen, the command used in the description of the issue is make gen-sdk-grpc, which only generate the files for the default SDK_FOLDER=go, but not the node one

Good catch, typo on my end. I'll update the bug title to make gen-all-sdk-grpc. This should generate for nodejs (and for all "supported" languages in general).

I can make an PR to update it to beta if you want though ?

If you're able to get the make run-sdk-command COMMAND=gen SDK_FOLDER=node to work that would be amazing.

I've been able to generate it, not sure if we want to keep both alpha and beta ?

[steven-supersolid]

We'll need to generate this manually for node.js and commit to the repo
We'll need both alpha and beta - alpha appears to be working so should be no change, beta may require a new line in the script

[steven-supersolid]

build/build-sdk-images/node/gen.sh needs updating with a line similar to alpha line for each export

e.g. these are the alpha lines. Also see gen.sh in go for how there is a generation line per feature stage

grpc_tools_node_protoc -I ${googleapis} -I ${gatewaygrpc} -I ${sdk}/alpha --js_out=import_style=commonjs,binary:./sdks/nodejs/lib/alpha google/api/annotations.proto google/api/client.proto google/api/field_behavior.proto google/api/http.proto google/api/launch_stage.proto google/api/resource.proto protoc-gen-openapiv2/options/annotations.proto protoc-gen-openapiv2/options/openapiv2.proto

grpc_tools_node_protoc -I ${googleapis} -I ${gatewaygrpc} -I ${sdk}/alpha --grpc_out=generate_package_definition:./sdks/nodejs/lib/alpha --js_out=import_style=commonjs,binary:./sdks/nodejs/lib/alpha alpha.proto

[steven-supersolid]

I've done this in my branch so can commit there or wait if we want to keep this separate. Not tested yet so the first command may need changes if additional google/api entries were used

grpc_tools_node_protoc -I ${googleapis} -I ${gatewaygrpc} -I ${sdk}/beta --js_out=import_style=commonjs,binary:./sdks/nodejs/lib/beta google/api/annotations.proto google/api/client.proto google/api/field_behavior.proto google/api/http.proto google/api/launch_stage.proto google/api/resource.proto protoc-gen-openapiv2/options/annotations.proto protoc-gen-openapiv2/options/openapiv2.proto

grpc_tools_node_protoc -I ${googleapis} -I ${gatewaygrpc} -I ${sdk}/beta --grpc_out=generate_package_definition:./sdks/nodejs/lib/beta --js_out=import_style=commonjs,binary:./sdks/nodejs/lib/beta beta.proto