GithubHelp home page GithubHelp logo

Comments (5)

kung-foo avatar kung-foo commented on July 29, 2024 1

@sruehl is there overlap with the issue described here? #619

from opcua.

sruehl avatar sruehl commented on July 29, 2024

@magiconair could it be that this todo is the root cause?
node_id.go:16 "// todo(fs): fix mask"

from opcua.

sruehl avatar sruehl commented on July 29, 2024

#683 fixes the issue

from opcua.

sruehl avatar sruehl commented on July 29, 2024

I think it is basically the same Problem. Although I like the way #619 is a bit more efficient I would prefer having a NodeFromExpandedNode factory function which copies the values and set's the mask like it is done in #619. The function there called RemoveExpandedFlag doesn't make much sense outside the copy scenario. My approach does that externals so the NodeFromExpandedNode would be more efficient because it has access to the private fields. I could update the PR with that suggestion if wanted.

from opcua.

sruehl avatar sruehl commented on July 29, 2024

my approach == #683

from opcua.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.