Comments (4)
Tested on Win 10, Chrome 68 and Firefox 59.0.2, uBlock Origin 1.15.24.
Part of the problem can be reproduced on Ubuntu 17.10.
The fix might not be straight forward, Windows happily accept http://a--t--.test.jspenguin.com/
as valid address but Ubuntu doesn't like it. Note that http://---.test.jspenguin.com/
is not accepted in Windows.
Maybe just lift the restriction and accept anything that looks remotely reasonable as valid?
µBlock.reWhitelistBadHostname = /[^a-z0-9.\-_\[\]:]/;
µBlock.reWhitelistHostnameExtractor = /([a-z0-9.\-_\[\]]+)(?::[\d*]+)?\/(?:[^\x00-\x20\/]|$)[^\x00-\x20]*$/;
from ublock.
Maybe just lift the restriction and accept anything that looks remotely reasonable as valid?
Yes, as long as a hostname can be extracted -- valid or not.
from ublock.
Well since you are almost there, can you submit a pull request with the modified regexes?
from ublock.
Fixed with PR #3718.
from ublock.
Related Issues (20)
- New issue tracker is at https://github.com/uBlockOrigin/uBlock-issues/issues HOT 4
- Ublock origin crashes on Chrome
- Softonic HOT 2
- Please don't leave Windows XP users alone HOT 1
- placeholder in whitelist to whitelist subdomains HOT 4
- uBlock Origin prevented the page from loading: HOT 7
- Deploying uBlock Origin to machines with Firefox HOT 2
- Questions about how uBlock works HOT 1
- [Feature] Add to filters, unchecked by default, Adblock nonintrusive advertising and AakList HOT 1
- SoundCloud ads are no longer being blocked HOT 1
- No window action buttons HOT 1
- Please allow to run on router
- 开启插件后芒果视频网页版无法正常登录 HOT 1
- Youtube adds
- can i install ublock origin for all browsers silently (automatically)? HOT 1
- blocking is ok but the site is not functional - how to overcome?
- Ublock blocks some comments section
- A script that blocks a microphone on Google Translate for Firefox
- Apple Extensions for MacOS / iPad OS HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ublock.