Comments (6)
Hi @donnol,
I believe this is expected and cannot be considered as a bug because:
- when you do not use the schema tag, schema uses the field name in lower case to decode, and therefore:
type Outer struct {
Page
}
is equivalent to:
type Outer struct {
Page `schema:"page"`
}
when you try to decode map[string][]string{"page": {"1"}}
you are trying to decode a string into a struct which schema does know how to do. To work around it, you need to use the full path in your query string: map[string][]string{"page.page": {"1"}, "page.pageSize": {"22"}}
from schema.
@donnol Does my answer help ? because schema uses reflection, it's only aware of the Page
field. I know in golang that embedding a struct is like unwrapping all the fields inside the target struct, so doing pp.PageSize
works as well as doing pp.Page.PageSize
. However, reflection only sees the embedded struct field:
tp := reflect.TypeOf(Outer{})
//prints 1
fmt.Println(tp.NumField())
i := 0
for i < tp.NumField() {
fmt.Println(tp.Field(i).Name)
i++
}
//prints Page
I hope this helps.
from schema.
{
tp := reflect.TypeOf(Outer{})
//prints 1
fmt.Println(tp.NumField())
i := 0
for i < tp.NumField() {
if tp.Field(i).Anonymous {
fmt.Println("anonymous", tp.Field(i).Type, tp.Field(i).Type.NumField())
}
fmt.Println(tp.Field(i).Name)
i++
}
}
I think we can use tp.Field(i).Anonymous
to identify a field if is Anonymous , and then get its inner field.
from schema.
I believe it should be feasible, thanks for the information. I propose adding a flag when decoding/encoding that can define the behavior of the decoder/encoder when dealing embded structs. The flag can define whether we need to unwrap the structs or just treat them as a field. We can name it for example UnwrapEmbeddedStructs
. Based on the valuie of the field, we can check for Anonymous
and take it from there. This would keep things backward compatible.
from schema.
Related Issues (20)
- [bug] Required check bypassed if there is another field whose prefix is the field HOT 3
- [question] Unable to decode slice of structs HOT 1
- [feature] New release/tag HOT 1
- [feature] default values for scheme struct fields HOT 13
- [feature] Use json struct tags if wanted HOT 2
- [question] "+" symbol HOT 6
- ⚠️ The Gorilla Toolkit is Looking for a New Maintainer HOT 10
- [bug] Unstable decoding of different keys that are case-folded to the same value HOT 1
- Not checking for nil might lead to nil pointer dereference HOT 4
- [question] Error converting into []byte or []uint8 HOT 2
- [question] Why can't Encoder check and call fmt.Stringer.String() on element automatically? HOT 1
- [BUG] v1.2.0 Cannot decode into slice of strings HOT 2
- [bug] need to skip unexported field HOT 2
- [BUG] Nested struct with required field is not failing on decode HOT 1
- [FEATURE] Documentation HOT 4
- [Question] Is ignoring mismatched slice element types intended behavior? HOT 3
- [BUG] panic in 1.3.0 HOT 6
- [Question] Form encoding/decoding ignores slice of struct HOT 4
- [BUG] Slice encoding drops empty values rather than encoding them as `nil` or default HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from schema.