Comments (3)
Hi @lll-lll-lll-lll, thanks. It seems like this is intentional, but I honestly do not recall the reasons behind the choice because it has been a while since I submitted the PR. Maybe it was because default
was considered as something optional and therefore should not break the decoding, no matter what. There is also a test case for this behavior: https://github.com/gorilla/schema/blob/main/decoder_test.go#L2217
I like the idea of failing when a default value that do not match the type is provided. This would enforce correctness and notify when some unexpected value is used. It's certainly a plus.
@AlexVulaj, @jaitaiwan what do you think ?
from schema.
I'm in agreement with @zak905 here - I think it's better to handle cases with an unexpected value. Please feel free to submit a PR for this change and tag me in it, thanks!
from schema.
Thank you, I will try to make a PR!
from schema.
Related Issues (20)
- [feature] New release/tag HOT 1
- [feature] default values for scheme struct fields HOT 13
- [feature] Use json struct tags if wanted HOT 2
- [question] "+" symbol HOT 6
- ⚠️ The Gorilla Toolkit is Looking for a New Maintainer HOT 10
- [bug] Unstable decoding of different keys that are case-folded to the same value HOT 1
- Not checking for nil might lead to nil pointer dereference HOT 4
- [question] Error converting into []byte or []uint8 HOT 2
- [bug] schema: converter not found for Page, when the struct name is same with field name. HOT 6
- [question] Why can't Encoder check and call fmt.Stringer.String() on element automatically? HOT 1
- [BUG] v1.2.0 Cannot decode into slice of strings HOT 2
- [bug] need to skip unexported field HOT 2
- [BUG] Nested struct with required field is not failing on decode HOT 1
- [FEATURE] Documentation HOT 4
- [BUG] panic in 1.3.0 HOT 6
- [Question] Form encoding/decoding ignores slice of struct HOT 4
- [BUG] Slice encoding drops empty values rather than encoding them as `nil` or default HOT 3
- [FEATURE] Use omitempty by default HOT 4
- [BUG] nil pointer values are encoded as "null" and not decodable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from schema.