Can't unmarshal type []string correctly with error schema.MultiError about schema

[FDePourcq]

For me decoding a comma-separated list of numbers to a slice of numbers works, but not to a slice of strings. In that case it simply dumps the entire string in the first element of the slice. So with input "key=some,string" I got ["some,strings"] instead of ["some", "strings"].

My guess is that the item := conv(value); item.IsValid() at https://github.com/gorilla/schema/blob/master/decoder.go#L209 evaluates to true a bit too eagerly, and that the check with its associated code-block must switch place with the strings.Contains(value, ",") -code-block at https://github.com/gorilla/schema/blob/master/decoder.go#L220

[thomasmodeneis]

Hey, anyone have any idea ?

Cheers.

[elithrar]

schema is looking for key=value pairs. If you have tags[] with the escaped versions of [], then you will have to have that in the struct tag.

What is the behaviour you are expecting otherwise?

[oldfeel]

In

schema/cache.go

Line 190 in afe7739

ss: isSlice && isStruct,

This line set []string not slice,

ss:       isSlice && isStruct,

Change to this is ok.

ss:       isSlice,

[stale]

This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.