SNMP Set Integer is limited to 255 values. about gosnmp

[soniah]

Thanks! Have I missed the pull request? Or would you mind making one? :-)

[MrSpock]

Sonia,

Somehow it merged with my previous pull-request regarding SnmpSET OctetString.
At least I see in this pull-req diff new code for IPAddress type support I made and fix for Integer handling with additional helper function.
Please let me know if you see that too .

[soniah]

Great thanks

[soniah]

16 bit integer committed with dea03ab - thanks.

Next step - ipaddress.

[soniah]

Hi Marcin. I've setup two branches 'soniah/set_octetstring' and 'soniah/set_ipaddress'. I'm trying to tidy up your code :-) and work out what's happening.

I've downloaded your pcap from https://dl.dropboxusercontent.com/u/7660386/github/snmpset_native.pcap for two integers and two OctetStrings. Would you be able to put up a pcap for ipaddresses?

Sorry if I sound a little confused - I had surgery 8 days ago and I'm a bit tired... :-/

But I appreciate your contributions! :-)

[soniah]

See also #26

[MrSpock]

Sonia,
I made slightly wrong in boundary check in code you commited.
Line:
if value > 0xff && value < 0xffff
Should be:
if value > 0xff && value <= 0xffff

Second comparision should cover 0xffff also :)
With current code you can't set 0xffff (65535) value.

[soniah]

Thanks, fixed :-) I've rebased 'soniah/set_octetstring' and 'soniah/set_ipaddress', so you'll need to pull again if you pulled in the last 15 mins.

[MrSpock]

Sonia,
Not a problem.
Difference between OctetString and IPAddres is only one byte (packet type
in varbind). Maybe it is worth to separate some common code.
I will provide you with pcap files.
6 wrz 2014 14:56 "Sonia Hamilton" [email protected] napisał(a):

Hi Marcin. I've setup two branches 'soniah/set_octetstring' and
'soniah/set_ipaddress'. I'm trying to tidy up your code :-) and work out
what's happening.

I've downloaded your pcap from
https://dl.dropboxusercontent.com/u/7660386/github/snmpset_native.pcap
for two integers and two OctetStrings. Would you be able to put up a pcap
for ipaddresses?

Sorry if I sound a little confused - I had surgery 8 days ago and I'm a
bit tired... :-/

—
Reply to this email directly or view it on GitHub
#30 (comment).

[soniah]

Tests written, tidied, merged. Thanks very much!