hash_map_free bug about c-utils

[sidcha]

@tuchun, yes that is a bug. Thanks for reporting it.

Do you want to send a pull request for this change? Since you found and fixed it, you might as well commit it :)

[codemanchris]

@tuchun, yes that is a bug. Thanks for reporting it.

Do you want to send a pull request for this change? Since you found and fixed it, you might as well commit it :)

No ^_^, just fix it, there is also a problem with the test , free is called after delete, so cannot be tested correctly.

TEST_DEF(hashmap)
{
	char *buf;
	const char * const *words;
	size_t size, count;
	hash_map_t map;
	TEST_MOD_INIT();

	TEST_MOD_READ_FILE("words_alpha.txt", &buf, &size);
	count = test_build_word_list(buf, &words);

	hash_map_init(&map);

	TEST_MOD_EXEC( test_dict_insert(&map, words, count) );
	TEST_MOD_EXEC( test_dict_iterator(&map, words, count) );
        //test_dict_delete has freed the map
	TEST_MOD_EXEC( test_dict_delete(&map, words, count) );
	TEST_MOD_EXEC( map.count );

        //so hash_map_free not covered by tests
	hash_map_free(&map, free_test_hashmap_value);

	safe_free(buf);
	safe_free((void *)words);
	TEST_MOD_REPORT();
}

[sidcha]

One bug covering for another, very typical. 🤯

Thanks, fixed both.