GithubHelp home page GithubHelp logo

Comments (8)

Gottox avatar Gottox commented on August 26, 2024

Hi @peenuty !

Thanks for pointing this out. socket.io doesn't handle query strings very well. The problem about your approach is, that an IOConnection can be multiplexed. That means, different SocketIO instances can use the same IOConnection. If you send different query strings over a multiplexed connection, only the first one gets sent to the server.

Actually, this buggy approach is the way it is done in @LearnBoost socket.io implementation. So, I consider following this. But I suspect that this leads to nasty bugs.

Enno

PS: There's a bugreport for this issue with an apt title: socketio/socket.io-client#331

from socket.io-java-client.

Gottox avatar Gottox commented on August 26, 2024

The issue is still open, but it's a protocol issue, not a socket.io-java-client specific one. I'm hoping for protocol revision 1.0 to fix this issue.

For now, query strings are not supported by socket.io-java-client.

from socket.io-java-client.

YongGang avatar YongGang commented on August 26, 2024

socket.io support connect with querystring since 0.9.6, socketio/socket.io-client#467
Could you please fix the java client?

from socket.io-java-client.

cendrizzi avatar cendrizzi commented on August 26, 2024

This would be really nice. Other than this single feature everything is working great with this client.

from socket.io-java-client.

fatshotty avatar fatshotty commented on August 26, 2024

any news?

from socket.io-java-client.

fatshotty avatar fatshotty commented on August 26, 2024

I have pushed the query string integration in my fork but I cannot send pull-request.
I will ping @Gottox soon

here is my commit: fatshotty@bf08624#commitcomment-3446681

from socket.io-java-client.

fatshotty avatar fatshotty commented on August 26, 2024

version 0.2.1 has been deployed on maven repo.
It contains all changes and also this issue fixed

from socket.io-java-client.

sanakanchha avatar sanakanchha commented on August 26, 2024

Hello fatshotty,
great that your fork has the maven dependency and querystrings support. Because maven would be way easier for me to implement. A quick question: Does your fork 0.2.1 include everything thats on Gottox/socket.io-java-client?

from socket.io-java-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.