NX 13.5.3 breaks nx-docker on GHA about nx-tools

[JWood48]

Also an issue on 13.6.1

[DaSchTour]

@MkMan try with 13.7.1

[DaSchTour]

It's also an issue with Jenkins. Any ideas where/why this is happening?

Maybe related to this one: nrwl/nx#8565

[gperdomor]

Mmmm... that's weird, try with the latest version of nx and take a look to this repository: https://github.com/gperdomor/nx-docker-sandbox where it's working fine

[DaSchTour]

Well my branch with version 1.1.0-alpha.3 works with nx 13.7.1
My branch where I tried to upgrade to nx-docker 2.2.0 failes with

error: tag is needed when pushing to registry
buildx failed with: error: tag is needed when pushing to registry

[gperdomor]

@DaSchTour did you update your config too? This should help https://github.com/gperdomor/nx-tools/blob/main/packages/nx-docker/UPGRADE.md

[roderik]

I would categorise the diff between v1 and v2 as a different problem. We have been running v2 since before the stable releases, there is definitely no upgrade issue at play here

[roderik]

FYI, renovate just upgraded our repos to v13.7.1 of NX and everything built. So maybe it is solved. Nothing in the changelog stood out.

[DaSchTour]

I would categorise the diff between v1 and v2 as a different problem. We have been running v2 since before the stable releases, there is definitely no upgrade issue at play here

Yeah, it's different but's also somehow related. There is also this issue that relates to this: #362

I have my v1.1 build running again with 13.7.1. Have to verify if there is any possibility to get v2 working.

[MkMan]

I don't use nx-tools but I am also having this error when running Jest tests locally with Nx version 13.6.1.

[MkMan]

@MkMan try with 13.7.1

That worked. Thanks @DaSchTour